Re: [RFC PATCH 4/4] mfd: syscon: add ACPI support

Zhangfei Gao
2015-12-11T10:35:18Z

Hi, Arnd

On Wed, Dec 2, 2015 at 6:44 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 02 December 2015 17:09:28 Kefeng Wang wrote:
>> This enables syscon with ACPI support.
>> syscon_regmap_lookup_by_dev_property() function was added. With helper
>> device_get_reference_node() and acpi_dev_find_plat_dev(), it can be used
>> in both DT and ACPI.
>>
>> The device driver can obtain syscon using _DSD method in DSDT, an example
>> is shown below.
>>
>> Device(CTL0) {
>> Name(_HID, "HISI0061")
>> Name(_CRS, ResourceTemplate() {
>> Memory32Fixed(ReadWrite, 0x80000000, 0x10000)
>> })
>> }
>>
>> Device(DEV0) {
>> Name(_HID, "HISI00B1")
>> Name(_CRS, ResourceTemplate() {
>> Memory32Fixed(ReadWrite, 0x8c030000, 0x10000)
>> Interrupt(ResourceConsumer, Level, ActiveHigh, Exclusive){ 192 }
>> })
>>
>> Name (_DSD, Package () {
>> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>> Package () {
>> Package () {"syscon",Package() {\_SB.CTL0} }
>> }
>> })
>> }
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> This sounds like a bad idea:
>
> syscon is basically a hack to let us access register that the SoC designer
> couldn't fit in anywhere sane. We need something like this with devicetree
> because we decided not to have any interpreted bytecode to do this behind
> our back.
>
> With ACPI, the same thing is done with AML, which is actually nicer than
> syscon (once you have to deal with all the problems introduced by AML).
>
> Use that instead.
>

Would you mind clarifying AML method, still not understand.
Is is means realize the operation in uefi/bootloader and call some
interface from kernel?

The issue here is we want to access some common registers,
which we do not want to ioremap for many times in each driver.

In hisi platforms, we have many common registers shared by many components.

Thanks.

>> + pdev = acpi_dev_find_plat_dev(adev);
>> + if (!pdev)
>> + return ERR_PTR(-ENODEV);
>> + syscon = platform_get_drvdata(pdev);
>
> This still requires the syscon device to be probed first, which is
> something we shouldn't really need any more.
>
> A lot of syscon users depend on the regmap to be available before
> device drivers are loaded, so we have changed the code to just look up
> the device_node that is already present and ignore the device.
>
> Once clps711x has been converted to DT, I think we can rip out the
> syscon_regmap_lookup_by_pdevname() interface and separate the syscon
> regmap handling from the device handling that we only really need
> for debugfs.