From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3240AC433F5 for ; Sun, 13 Feb 2022 02:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232907AbiBMCUj convert rfc822-to-8bit (ORCPT ); Sat, 12 Feb 2022 21:20:39 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbiBMCUi (ORCPT ); Sat, 12 Feb 2022 21:20:38 -0500 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A79E25FF27 for ; Sat, 12 Feb 2022 18:20:32 -0800 (PST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-73-Q-v6TvLNNIq7os3zIscGRA-1; Sun, 13 Feb 2022 02:20:29 +0000 X-MC-Unique: Q-v6TvLNNIq7os3zIscGRA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Sun, 13 Feb 2022 02:20:27 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.028; Sun, 13 Feb 2022 02:20:27 +0000 From: David Laight To: 'Kees Cook' , Ard Biesheuvel CC: Victor Erminpour , Robin Murphy , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , "ACPI Devel Maling List" , Linux ARM , Linux Kernel Mailing List , "trivial@kernel.org" Subject: RE: [PATCH v2] ACPI/IORT: Fix GCC 12 warning Thread-Topic: [PATCH v2] ACPI/IORT: Fix GCC 12 warning Thread-Index: AQHYHtiyz9LUyAjRSUu2IalWh5Ct1KyQwgtg Date: Sun, 13 Feb 2022 02:20:27 +0000 Message-ID: <26dee09f5fc8420782e4556d86c55a04@AcuMS.aculab.com> References: <1644518851-16847-1-git-send-email-victor.erminpour@oracle.com> <202202101415.43750CEE@keescook> In-Reply-To: <202202101415.43750CEE@keescook> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Kees Cook > Sent: 10 February 2022 23:47 ... > All that said, I think this patch could be improved. > > I'd recommend, instead, just simply: > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index f2f8f05662de..9e765d30da82 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1671,13 +1671,14 @@ phys_addr_t __init acpi_iort_dma_get_max_cpu_address(void) > end = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->header.length); > > for (i = 0; i < iort->node_count; i++) { > + struct acpi_iort_named_component *ncomp; > + struct acpi_iort_root_complex *rc; > + phys_addr_t local_limit; > + I'd move them right to the top of the function. No point hiding the declarations in the middle. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)