From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: Len Brown <lenb@kernel.org>, "Zheng, Lv" <lv.zheng@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Brown, Len" <len.brown@intel.com>,
linux acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package entries
Date: Tue, 18 Jun 2013 23:50:06 +0200 [thread overview]
Message-ID: <2701902.tBNGLava1W@vostro.rjw.lan> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E36FE8856C@ORSMSX103.amr.corp.intel.com>
On Tuesday, June 18, 2013 06:52:12 PM Moore, Robert wrote:
> This change fixes a bug in the original _CST repair code.
Well, in that case the changelog should explain what the bug is/was.
Thanks,
Rafael
> > -----Original Message-----
> > From: lenb417@gmail.com [mailto:lenb417@gmail.com] On Behalf Of Len Brown
> > Sent: Wednesday, June 12, 2013 11:00 AM
> > To: Zheng, Lv
> > Cc: Wysocki, Rafael J; Moore, Robert; Brown, Len; linux acpi
> > Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package
> > entries
> >
> > On Fri, Jun 7, 2013 at 9:01 PM, Lv Zheng <lv.zheng@intel.com> wrote:
> > > Sort package only after null/bad elements have been removed.
> > > Lv Zheng.
> >
> >
> > again, please explain WHY.
> >
> > Every line of change to the kernel adds risk.
> > I see no justification in this commit message why any risk should be added
> > to the kernel.
> >
> > Nacked-by: Len Brown <len.brown@intel.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-06-18 21:40 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 0:57 [PATCH 00/16] ACPICA: 20130517 release Lv Zheng
2013-06-08 0:57 ` [PATCH 01/16] ACPICA: Split buffer dump routines into separate file Lv Zheng
2013-06-12 15:51 ` Len Brown
2013-06-08 0:58 ` [PATCH 02/16] ACPICA: Split internal error msg routines to a " Lv Zheng
2013-06-12 15:52 ` Len Brown
2013-06-08 0:58 ` [PATCH 03/16] ACPICA: Standardize all switch() blocks Lv Zheng
2013-06-12 15:58 ` Len Brown
2013-06-18 18:46 ` Moore, Robert
2013-06-08 0:58 ` [PATCH 04/16] ACPICA: Add option to disable loading of SSDTs from the RSDT/XSDT Lv Zheng
2013-06-08 0:59 ` [PATCH 05/16] ACPICA: Split table print utilities to a new a separate file Lv Zheng
2013-06-12 17:03 ` Len Brown
2013-06-18 18:46 ` Moore, Robert
2013-06-08 0:59 ` [PATCH 06/16] ACPICA: Do not use extended sleep registers unless HW-reduced bit is set Lv Zheng
2013-06-12 17:11 ` Len Brown
2013-06-15 23:08 ` Rafael J. Wysocki
2013-06-08 0:59 ` [PATCH 07/16] ACPICA: New: Portable acpidump utility (get system ACPI tables) Lv Zheng
2013-06-12 17:07 ` Len Brown
2013-06-15 23:09 ` Rafael J. Wysocki
2013-06-18 18:53 ` Moore, Robert
2013-06-18 21:06 ` Rafael J. Wysocki
2013-06-18 21:21 ` Moore, Robert
2013-06-18 21:40 ` Rafael J. Wysocki
2013-06-19 0:48 ` Moore, Robert
2013-06-19 23:10 ` Rafael J. Wysocki
2013-06-20 4:57 ` Moore, Robert
2013-06-20 19:42 ` Rafael J. Wysocki
2013-06-20 19:43 ` Moore, Robert
2013-06-18 18:48 ` Moore, Robert
2013-06-08 0:59 ` [PATCH 08/16] ACPICA: Update interface to AcpiUtValidAcpiName Lv Zheng
2013-06-12 17:15 ` Len Brown
2013-06-15 23:12 ` Rafael J. Wysocki
2013-06-08 0:59 ` [PATCH 09/16] ACPICA: ACPICA Termination: Delete global lock pending lock Lv Zheng
2013-06-12 17:28 ` Len Brown
2013-06-08 1:00 ` [PATCH 10/16] ACPICA: Fix possible memory leak in GPE init error path Lv Zheng
2013-06-12 17:34 ` Len Brown
2013-06-08 1:00 ` [PATCH 11/16] ACPICA: Clear events initialized flag upon event component termination Lv Zheng
2013-06-12 17:47 ` Len Brown
2013-06-18 18:50 ` Moore, Robert
2013-06-08 1:00 ` [PATCH 12/16] ACPICA: Support Mac OS X in Makefile Lv Zheng
2013-06-12 17:49 ` Len Brown
2013-06-08 1:01 ` [PATCH 13/16] ACPICA: Move _PRT repair into the standard complex repair module Lv Zheng
2013-06-12 17:52 ` Len Brown
2013-06-15 23:17 ` Rafael J. Wysocki
2013-06-18 18:51 ` Moore, Robert
2013-06-18 21:49 ` Rafael J. Wysocki
2013-06-19 23:57 ` Rafael J. Wysocki
2013-06-20 0:41 ` Zheng, Lv
2013-06-20 5:01 ` Moore, Robert
2013-06-08 1:01 ` [PATCH 14/16] ACPICA: Add several repairs for _CST predefined name Lv Zheng
2013-06-12 17:58 ` Len Brown
2013-06-15 23:17 ` Rafael J. Wysocki
2013-06-18 18:51 ` Moore, Robert
2013-06-18 21:48 ` Rafael J. Wysocki
2013-06-19 0:52 ` Moore, Robert
2013-06-19 23:57 ` Rafael J. Wysocki
2013-06-08 1:01 ` [PATCH 15/16] ACPICA: _CST repair: Handle null package entries Lv Zheng
2013-06-12 18:00 ` Len Brown
2013-06-15 23:18 ` Rafael J. Wysocki
2013-06-17 16:41 ` Moore, Robert
2013-06-17 20:31 ` Rafael J. Wysocki
2013-06-18 21:51 ` Rafael J. Wysocki
2013-06-18 18:52 ` Moore, Robert
2013-06-18 21:50 ` Rafael J. Wysocki [this message]
2013-06-19 0:50 ` Moore, Robert
2013-06-19 23:56 ` Rafael J. Wysocki
2013-06-08 1:01 ` [PATCH 16/16] ACPICA: Update version to 20130517 Lv Zheng
2013-06-12 18:01 ` Len Brown
2013-06-15 23:19 ` Rafael J. Wysocki
2013-06-11 22:32 ` [PATCH 00/16] ACPICA: 20130517 release Rafael J. Wysocki
2013-06-12 18:04 ` Len Brown
2013-06-15 23:24 ` Rafael J. Wysocki
2013-06-18 1:39 ` Zheng, Lv
2013-06-18 1:56 ` Zheng, Lv
2013-06-18 10:35 ` Rafael J. Wysocki
2013-06-18 18:55 ` Moore, Robert
2013-06-18 21:04 ` Rafael J. Wysocki
2013-06-19 0:58 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2701902.tBNGLava1W@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox