From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: luanshi <zhangliguang@linux.alibaba.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3] ACPI / APEI: Remove needless __ghes_check_estatus() calls
Date: Fri, 05 Jul 2019 11:42:40 +0200 [thread overview]
Message-ID: <2740228.kq3QBCH7cy@kreacher> (raw)
In-Reply-To: <1561439728-5223-1-git-send-email-zhangliguang@linux.alibaba.com>
On Tuesday, June 25, 2019 7:15:28 AM CEST luanshi wrote:
> Function __ghes_check_estatus() is always called after
> __ghes_peek_estatus(), but it is already called in __ghes_peek_estatus().
> So we should remove some needless __ghes_check_estatus() calls.
>
> Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
> Reviewed-by: James Morse <james.morse@arm.com>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 993940d..a66e00f 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -345,7 +345,7 @@ static int __ghes_peek_estatus(struct ghes *ghes,
> return -ENOENT;
> }
>
> - return __ghes_check_estatus(ghes, estatus);
> + return 0;
> }
>
> static int __ghes_read_estatus(struct acpi_hest_generic_status *estatus,
>
Applied, thanks!
prev parent reply other threads:[~2019-07-05 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 5:15 [PATCH v3] ACPI / APEI: Remove needless __ghes_check_estatus() calls luanshi
2019-07-05 9:42 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2740228.kq3QBCH7cy@kreacher \
--to=rjw@rjwysocki.net \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox