From: Arnd Bergmann <arnd@arndb.de>
To: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v5 1/2] Mailbox: Add support for Platform Communication Channel
Date: Thu, 04 Sep 2014 16:55:38 +0200 [thread overview]
Message-ID: <2751441.DbtaX4JgI6@wuerfel> (raw)
In-Reply-To: <CAJ5Y-eaBMX_YGxL69AwKdq3y5n+XFsbD2J7AfHq197ST6AgCjQ@mail.gmail.com>
On Thursday 04 September 2014 10:48:00 Ashwin Chaugule wrote:
>
> >> + * Create a virtual device to back the PCCT, so
> >> + * that the generic Mailbox framework can do its
> >> + * ref counting.
> >> + */
> >> +struct platform_device pcc_pdev = {
> >> + .name = "PCCT",
> >> +};
> >
> > Don't declare platform devices statically in C code, just
> > use platform_create_bundle() here to create the device dynamically
> > and bind it to the driver. That will also simplify the driver
> > initalization.
> >
>
> Nice. Didn't know about this.
It's almost always inappropriate, but I guess here it makes sense.
Normally we want drivers to be loadable when the device shows up,
but you can't do that here anyway.
Arnd
next prev parent reply other threads:[~2014-09-04 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 22:19 [PATCH v5 0/2] PCC: Platform Communication Channel Ashwin Chaugule
2014-09-03 22:19 ` [PATCH v5 1/2] Mailbox: Add support for " Ashwin Chaugule
2014-09-04 4:35 ` Zheng, Lv
2014-09-04 4:38 ` Zheng, Lv
2014-09-04 14:31 ` Ashwin Chaugule
[not found] ` <5470309.KpxVtJyk9p@wuerfel>
2014-09-04 14:48 ` Ashwin Chaugule
2014-09-04 14:55 ` Arnd Bergmann [this message]
2014-09-04 17:24 ` Ashwin Chaugule
2014-09-04 19:00 ` [Linaro-acpi] " Arnd Bergmann
2014-09-04 19:07 ` Ashwin Chaugule
2014-09-04 22:20 ` Mark Brown
2014-09-03 22:19 ` [PATCH v5 2/2] PCC test Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2751441.DbtaX4JgI6@wuerfel \
--to=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=broonie@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox