From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c Date: Wed, 18 Dec 2013 02:08:46 +0100 Message-ID: <2756776.dGKMpKb0nz@vostro.rjw.lan> References: <94F2FBAB4432B54E8AACC7DFDE6C92E37C7B99F5@ORSMSX103.amr.corp.intel.com> <20131217202518.GA17790@jtriplet-mobl1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:53282 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751001Ab3LRAz2 convert rfc822-to-8bit (ORCPT ); Tue, 17 Dec 2013 19:55:28 -0500 In-Reply-To: <20131217202518.GA17790@jtriplet-mobl1> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Josh Triplett , "Moore, Robert" , "Zheng, Lv" Cc: Rashika Kheria , "linux-kernel@vger.kernel.org" , "Wysocki, Rafael J" , Len Brown , "linux-acpi@vger.kernel.org" , "devel@acpica.org" On Tuesday, December 17, 2013 12:25:18 PM Josh Triplett wrote: > On Tue, Dec 17, 2013 at 05:35:46PM +0000, Moore, Robert wrote: > > I'm not sure what version of ACPICA you are looking at, but in the = master git tree for ACPICA, the file accommon.h includes "acutils.h". >=20 > This is the version in the latest git tree for the Linux kernel. Well, I guess that's something for Lv to look at, then. Lv, we seem to have a divergence here, can you please see if we can fix= it shortly? Rafael > > > -----Original Message----- > > > From: Rashika Kheria [mailto:rashika.kheria@gmail.com] > > > Sent: Tuesday, December 17, 2013 1:22 AM > > > To: linux-kernel@vger.kernel.org > > > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux= - > > > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org > > > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header = file in > > > utstate.c > > >=20 > > > Include appropriate header file acutils.h in acpica/utstate.c bec= ause > > > function acpi_ut_create_pkg_state_and_push() has its prototype de= claration > > > in acutils.h. Also, encloses the function in acpica/utstate.c in = ifdef > > > condition of ACPI_FUTURE_USAGE. > > >=20 > > > This eliminates the following warning in utstate.c: > > > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototyp= e for > > > =E2=80=98acpi_ut_create_pkg_state_and_push=E2=80=99 [-Wmissing-pr= ototypes] > > >=20 > > > Signed-off-by: Rashika Kheria > > > Reviewed-by: Josh Triplett > > > --- > > > drivers/acpi/acpica/utstate.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > >=20 > > > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/= utstate.c > > > index 03c4c2f..0920d23 100644 > > > --- a/drivers/acpi/acpica/utstate.c > > > +++ b/drivers/acpi/acpica/utstate.c > > > @@ -43,6 +43,7 @@ > > >=20 > > > #include > > > #include "accommon.h" > > > +#include "acutils.h" > > >=20 > > > #define _COMPONENT ACPI_UTILITIES > > > ACPI_MODULE_NAME("utstate") > > > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate") > > > * DESCRIPTION: Create a new state and push it > > > * > > >=20 > > > *****************************************************************= ********* > > > ****/ > > > +#ifdef ACPI_FUTURE_USAGE > > > acpi_status > > > acpi_ut_create_pkg_state_and_push(void *internal_object, > > > void *external_object, > > > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *interna= l_object, > > > acpi_ut_push_generic_state(state_list, state); > > > return (AE_OK); > > > } > > > +#endif > > >=20 > > >=20 > > > /****************************************************************= ********* > > > ****** > > > * > > > -- > > > 1.7.9.5 > >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html