From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Colin King <colin.king@canonical.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: APD: remove redundant assignment to pointer clk
Date: Fri, 05 Jul 2019 11:41:35 +0200 [thread overview]
Message-ID: <2921052.OUaa6v4X4N@kreacher> (raw)
In-Reply-To: <20190702131029.9621-1-colin.king@canonical.com>
On Tuesday, July 2, 2019 3:10:29 PM CEST Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer clk is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/acpi/acpi_apd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index ff47317d8ef1..7cd0c9ac71ea 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -57,7 +57,7 @@ struct apd_private_data {
> static int acpi_apd_setup(struct apd_private_data *pdata)
> {
> const struct apd_device_desc *dev_desc = pdata->dev_desc;
> - struct clk *clk = ERR_PTR(-ENODEV);
> + struct clk *clk;
>
> if (dev_desc->fixed_clk_rate) {
> clk = clk_register_fixed_rate(&pdata->adev->dev,
>
Applied, thanks!
prev parent reply other threads:[~2019-07-05 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 13:10 [PATCH] ACPI: APD: remove redundant assignment to pointer clk Colin King
2019-07-05 9:41 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2921052.OUaa6v4X4N@kreacher \
--to=rjw@rjwysocki.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox