From: Julian Braha <julianbraha@gmail.com>
To: Kai-Heng Feng <kaihengf@nvidia.com>,
rafael@kernel.org, shuah@kernel.org, kees@kernel.org
Cc: csoto@nvidia.com, mochs@nvidia.com,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Hanjun Guo <guohanjun@huawei.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Len Brown <lenb@kernel.org>, Jonathan Cameron <jic23@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 3/4] ACPI: APEI: GHES: Add Grace and Vera KUnit coverage
Date: Fri, 12 Jun 2026 14:58:55 +0100 [thread overview]
Message-ID: <2941bab8-e61d-49f2-ac6d-30d58c8a16d2@gmail.com> (raw)
In-Reply-To: <20260612120929.28965-4-kaihengf@nvidia.com>
On 6/12/26 13:09, Kai-Heng Feng wrote:
> +config ACPI_APEI_GHES_NVIDIA_KUNIT_TEST
> + tristate "NVIDIA GHES vendor record handler KUnit tests"
> + depends on KUNIT && ACPI_APEI_GHES_NVIDIA
> + default KUNIT_ALL_TESTS
> + help
> + KUnit tests for NVIDIA GHES vendor CPER parser helpers.
> + They cover Grace helper decoding, Vera payload parsing, and
> + section routing.
> + They are enabled only for KUnit test builds.
> + They are not intended for production firmware paths.
> +
> + If unsure, say N.
> +
Hi Kai-Heng, could you hide this option from the Kconfig frontend
when KUNIT_ALL_TESTS is enabled?
E.g.:
tristate "NVIDIA GHES vendor record handler KUnit tests" if !KUNIT_ALL_TESTS
From Documentation/dev-tools/kunit/style.rst:
"This Kconfig entry must:
<snip>
* be visible only if ``CONFIG_KUNIT_ALL_TESTS`` is not enabled."
- Julian Braha
prev parent reply other threads:[~2026-06-12 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260612120929.28965-1-kaihengf@nvidia.com>
2026-06-12 12:09 ` [PATCH v1 1/4] ACPI: APEI: GHES: Refactor Grace decoder helpers Kai-Heng Feng
2026-06-12 12:09 ` [PATCH v1 2/4] ACPI: APEI: GHES: Add NVIDIA Vera decoder Kai-Heng Feng
2026-06-12 12:09 ` [PATCH v1 3/4] ACPI: APEI: GHES: Add Grace and Vera KUnit coverage Kai-Heng Feng
2026-06-12 13:58 ` Julian Braha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2941bab8-e61d-49f2-ac6d-30d58c8a16d2@gmail.com \
--to=julianbraha@gmail.com \
--cc=bp@alien8.de \
--cc=csoto@nvidia.com \
--cc=dave.jiang@intel.com \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=jic23@kernel.org \
--cc=kaihengf@nvidia.com \
--cc=kees@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mochs@nvidia.com \
--cc=nathan@kernel.org \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox