From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
Xiongfeng Wang <wangxiongfeng2@huawei.com>
Subject: Re: [PATCH 1/2] cpufreq : cppc: Break out if we match the HiSilicon cppc workaround
Date: Sun, 29 Dec 2019 23:47:47 +0100 [thread overview]
Message-ID: <2965934.S1MOicRWCW@kreacher> (raw)
In-Reply-To: <1577152590-25574-1-git-send-email-guohanjun@huawei.com>
On Tuesday, December 24, 2019 2:56:29 AM CET Hanjun Guo wrote:
> Bail out if we match the OEM information, to save some possible
> extra iteration. And update the code to fix minor coding style issue.
>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 8d8da76..d0ca300 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -39,7 +39,7 @@
> static struct cppc_cpudata **all_cpu_data;
>
> struct cppc_workaround_oem_info {
> - char oem_id[ACPI_OEM_ID_SIZE +1];
> + char oem_id[ACPI_OEM_ID_SIZE + 1];
> char oem_table_id[ACPI_OEM_TABLE_ID_SIZE + 1];
> u32 oem_revision;
> };
> @@ -93,8 +93,10 @@ static void cppc_check_hisi_workaround(void)
> for (i = 0; i < ARRAY_SIZE(wa_info); i++) {
> if (!memcmp(wa_info[i].oem_id, tbl->oem_id, ACPI_OEM_ID_SIZE) &&
> !memcmp(wa_info[i].oem_table_id, tbl->oem_table_id, ACPI_OEM_TABLE_ID_SIZE) &&
> - wa_info[i].oem_revision == tbl->oem_revision)
> + wa_info[i].oem_revision == tbl->oem_revision) {
> apply_hisi_workaround = true;
> + break;
> + }
> }
> }
>
>
Both this and the [2/2] applies as 5.6 material with reworked
subjects and changelog changes. Thanks!
next prev parent reply other threads:[~2019-12-29 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 1:56 [PATCH 1/2] cpufreq : cppc: Break out if we match the HiSilicon cppc workaround Hanjun Guo
2019-12-24 1:56 ` [PATCH 2/2] cpufreq: cppc: put the acpi table after successfully get it Hanjun Guo
2019-12-29 22:47 ` Rafael J. Wysocki [this message]
2019-12-30 12:10 ` [PATCH 1/2] cpufreq : cppc: Break out if we match the HiSilicon cppc workaround Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2965934.S1MOicRWCW@kreacher \
--to=rjw@rjwysocki.net \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox