* [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF
@ 2017-03-23 15:53 Sinan Kaya
2017-03-23 15:56 ` Timur Tabi
2017-03-25 2:56 ` Corey Minyard
0 siblings, 2 replies; 4+ messages in thread
From: Sinan Kaya @ 2017-03-23 15:53 UTC (permalink / raw)
To: linux-acpi, timur, sulrich
Cc: linux-arm-msm, linux-arm-kernel, Sinan Kaya, Rafael J. Wysocki,
Len Brown, linux-kernel
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver
to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.
IPMI_SSIF is an alternative BMC communication method. It allows BMC to be
accessed over an I2C bus instead of a standard interface.
Enabling ACPI_IPMI over IPMI_SSIF with this change.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/acpi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 83e5f7e..8767062 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -256,7 +256,7 @@ config ACPI_PROCESSOR
config ACPI_IPMI
tristate "IPMI"
- depends on IPMI_SI
+ depends on IPMI_SI||IPMI_SSIF
default n
help
This driver enables the ACPI to access the BMC controller. And it
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF
2017-03-23 15:53 [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya
@ 2017-03-23 15:56 ` Timur Tabi
2017-03-25 2:56 ` Corey Minyard
1 sibling, 0 replies; 4+ messages in thread
From: Timur Tabi @ 2017-03-23 15:56 UTC (permalink / raw)
To: Sinan Kaya, linux-acpi, sulrich
Cc: linux-arm-msm, linux-arm-kernel, Rafael J. Wysocki, Len Brown,
linux-kernel
On 03/23/2017 10:53 AM, Sinan Kaya wrote:
> + depends on IPMI_SI||IPMI_SSIF
Blank spaces around ||.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF
2017-03-23 15:53 [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya
2017-03-23 15:56 ` Timur Tabi
@ 2017-03-25 2:56 ` Corey Minyard
2017-03-25 14:03 ` Sinan Kaya
1 sibling, 1 reply; 4+ messages in thread
From: Corey Minyard @ 2017-03-25 2:56 UTC (permalink / raw)
To: Sinan Kaya, linux-acpi, timur, sulrich
Cc: linux-arm-msm, linux-arm-kernel, Rafael J. Wysocki, Len Brown,
linux-kernel
Oops, yes, this is an issue.
However, it should probably depend on IPMI_HANDLER, not the individual
interface types.
-corey
On 03/23/2017 10:53 AM, Sinan Kaya wrote:
> ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver
> to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.
>
> IPMI_SSIF is an alternative BMC communication method. It allows BMC to be
> accessed over an I2C bus instead of a standard interface.
>
> Enabling ACPI_IPMI over IPMI_SSIF with this change.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
> drivers/acpi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 83e5f7e..8767062 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -256,7 +256,7 @@ config ACPI_PROCESSOR
>
> config ACPI_IPMI
> tristate "IPMI"
> - depends on IPMI_SI
> + depends on IPMI_SI||IPMI_SSIF
> default n
> help
> This driver enables the ACPI to access the BMC controller. And it
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF
2017-03-25 2:56 ` Corey Minyard
@ 2017-03-25 14:03 ` Sinan Kaya
0 siblings, 0 replies; 4+ messages in thread
From: Sinan Kaya @ 2017-03-25 14:03 UTC (permalink / raw)
To: minyard, linux-acpi, timur, sulrich
Cc: linux-arm-msm, linux-arm-kernel, Rafael J. Wysocki, Len Brown,
linux-kernel
On 3/24/2017 10:56 PM, Corey Minyard wrote:
> Oops, yes, this is an issue.
>
> However, it should probably depend on IPMI_HANDLER, not the individual interface types.
>
Thanks for the review. I posted V3 with your recommendation.
> -corey
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-25 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 15:53 [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF Sinan Kaya
2017-03-23 15:56 ` Timur Tabi
2017-03-25 2:56 ` Corey Minyard
2017-03-25 14:03 ` Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox