From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB89C433FE for ; Fri, 11 Nov 2022 01:11:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiKKBLD (ORCPT ); Thu, 10 Nov 2022 20:11:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiKKBLC (ORCPT ); Thu, 10 Nov 2022 20:11:02 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0454386D; Thu, 10 Nov 2022 17:11:00 -0800 (PST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N7gcS3D5BzHvcF; Fri, 11 Nov 2022 09:10:32 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 09:10:58 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 09:10:57 +0800 Message-ID: <2c68bad6-9dd0-97de-7369-cf2ecf855b2d@huawei.com> Date: Fri, 11 Nov 2022 09:10:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 1/3] mailbox: pcc: rename platform interrupt bit macro name To: "Rafael J. Wysocki" CC: Sudeep Holla , , , , , , , , , , , References: <20221110015034.7943-1-lihuisong@huawei.com> <20221110015034.7943-2-lihuisong@huawei.com> <20221110102528.6kuznowxtqkouvlb@bogus> <4f167ee7-ad50-d66c-8bd7-811fa0e83cfd@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org 在 2022/11/11 3:29, Rafael J. Wysocki 写道: > On Thu, Nov 10, 2022 at 1:17 PM lihuisong (C) wrote: >> >> 在 2022/11/10 18:25, Sudeep Holla 写道: >>> On Thu, Nov 10, 2022 at 09:50:32AM +0800, Huisong Li wrote: >>>> Currently, the name of platform interrupt bit macro, ACPI_PCCT_DOORBELL, >>>> is not very appropriate. The doorbell is generally considered as an action >>>> when send mailbox data. Actually, the macro value comes from Platform >>>> Interrupt in Platform Communications Channel Global Flags. If the bit is >>>> '1', it means that the platform is capable of generating an interrupt to >>>> indicate completion of a command. >>>> >>> This is touching ACPICA header file, so it must be submitted to ACPICA >>> separately following the guidelines in the github and imported into the >>> kernel. >> Got it, thanks. >>> However, I don't see any point in this change. Yes the language "doorbell" >>> is not used in this particular context in the spec, but it is implicit from >>> other parts. I am not opposing the change though if Rafael is OK and ACPICA >>> project accepts it. >> @Rafael, what do you think? > Well, I wouldn't send a patch to make this change myself, but if you > really care about it, please submit an upstream ACPICA pull request in > the first place and we'll see. All right. Indeed, it doesn't matter. Ignore it. > .