Re: [PATCH] ACPI: video: Don't allow MFD devices to probe

["Nirujogi, Pratap" <pnirujog@amd.com>]

On 3/6/2026 7:37 AM, Rafael J. Wysocki wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Friday, March 6, 2026 1:17:19 PM CET Rafael J. Wysocki wrote:
>> On Fri, Mar 6, 2026 at 11:50 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>>
>>> On Fri, Mar 6, 2026 at 3:51 AM Mario Limonciello (AMD)
>>> <superm1@kernel.org> wrote:
>>>>
>>>> After ACPI video was converted into a platform device in
>>>> commit 02c057ddefef5 ("ACPI: video: Convert the driver to a platform one")
>>>> other devices that are MFD children of LNXVIDEO are being probed.
>>>> This isn't intended.
>>>>
>>>> During probe detect MFD cells and reject them.
>>>>
>>>> Fixes: 02c057ddefef5 ("ACPI: video: Convert the driver to a platform one")
>>>> Reported-by: Pratap Nirujogi <pnirujog@amd.com>
>>>> Closes: https://lore.kernel.org/regressions/007e3390-6b2b-457e-83c7-c794c5952018@amd.com/
>>>
>>> The link is broken, so I can't see what is really happening, but my
>>> guess is that MFD devices are created under the video bus device and
>>> they get the same device ID (confusingly enough).
>>>
>>>> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
>>>> ---
>>>>   drivers/acpi/acpi_video.c | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
>>>> index 3fa28f1abca38..2cb526775ac47 100644
>>>> --- a/drivers/acpi/acpi_video.c
>>>> +++ b/drivers/acpi/acpi_video.c
>>>> @@ -14,6 +14,7 @@
>>>>   #include <linux/init.h>
>>>>   #include <linux/types.h>
>>>>   #include <linux/list.h>
>>>> +#include <linux/mfd/core.h>
>>>>   #include <linux/mutex.h>
>>>>   #include <linux/input.h>
>>>>   #include <linux/backlight.h>
>>>> @@ -1988,6 +1989,9 @@ static int acpi_video_bus_probe(struct platform_device *pdev)
>>>>          int error;
>>>>          acpi_status status;
>>>>
>>>> +       if (mfd_get_cell(pdev))
>>>> +               return -ENODEV;
>>>
>>> If the above is the case, I'd prefer this check
>>>
>>>          if (!device->pnp.type.backlight)
>>>
>>> which should also work, but is more general.
>>
>> Well, this will not work if the ACPI companion is shared between
>> multiple devices.
>>
>> However, adding an MFD check here is a "works for me" change rather.
>>
My apologies for not being clear about what works on my end. When I said 
it works, I meant that the MFD check had fixed the noisy error messages 
below. However, this does not resolve the automatic probe issue of AMD 
ISP device.

[    5.337676] acpi device:14: Error installing notify handler
[    5.337682] acpi device:15: Error installing notify handler
[    5.337684] acpi device:16: Error installing notify handler


>> I think what needs to be done is to extend the duplication check (see
>> my patch from yesterday at
>> https://lore.kernel.org/linux-acpi/5663583.Sb9uPGUboI@rafael.j.wysocki/)
>> to detect the cases when another platform device (not necessarily a
>> child of the same parent) sharing the same ACPI companion is probed.
> 
> So, Pratap, can you please test the appended patch (untested so far)?
> 
I verified the appended patch and the results are same as the MFD check 
suggested by Mario. Automatic modprobe of AMD ISP device issue is still 
observed.

Based on my debugging so far, I can confirm both automatic AMD ISP 
device probe and camera works only when the MFD child devices do not 
inherit the parent device ACPI companion. I shall run a git bisect to 
identify the specific commit that is causing this issue in 7.0.

> ---
>   drivers/acpi/acpi_video.c |   22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -1978,16 +1978,38 @@ static int acpi_video_bus_put_devices(st
>          return 0;
>   }
> 
> +static bool acpi_video_bus_bound(struct acpi_device *adev)
> +{
> +       struct acpi_video_bus *video;
> +
> +       guard(mutex)(&video_list_lock);
> +
> +       list_for_each_entry(video, &video_bus_head, entry) {
> +               if (video->device == adev)
> +                       return true;
> +       }
> +
> +       return false;
> +}
> +
>   static int instance;
> 
>   static int acpi_video_bus_probe(struct platform_device *pdev)
>   {
>          struct acpi_device *device = ACPI_COMPANION(&pdev->dev);
> +       static DEFINE_MUTEX(probe_lock);
>          struct acpi_video_bus *video;
>          bool auto_detect;
>          int error;
>          acpi_status status;
> 
> +       /* Probe one video bus device at a time in case there are duplicates. */
> +       guard(mutex)(&probe_lock);
> +
> +       /* Bind only one platform device for the given ACPI companion. */
> +       if (acpi_video_bus_bound(device))
> +               return -EALREADY;
> +
>          status = acpi_walk_namespace(ACPI_TYPE_DEVICE,
>                                  acpi_dev_parent(device)->handle, 1,
>                                  acpi_video_bus_match, NULL,
> 
> 
> 
>