From mboxrd@z Thu Jan 1 00:00:00 1970 From: gengdongjiu Subject: Re: [PATCH v1 2/2] arm/arm64: KVM: Add KVM_GET/SET_VCPU_EVENTS Date: Mon, 4 Jun 2018 17:53:33 +0800 Message-ID: <2d6fda7c-653a-4a36-62fb-4e0fc25767b3@huawei.com> References: <1527772139-19665-1-git-send-email-gengdongjiu@huawei.com> <1527772139-19665-3-git-send-email-gengdongjiu@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Eric Northup Cc: rkrcmar@redhat.com, corbet@lwn.net, christoffer.dall@arm.com, Marc Zyngier , linux@armlinux.org.uk, Catalin Marinas , will.deacon@arm.com, KVM , linux-doc@vger.kernel.org, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 2018/6/2 5:22, Eric Northup wrote: > On Wed, May 30, 2018 at 10:04 PM Dongjiu Geng wrote: >> >> For the migrating VMs, user space may need to know the exception [...] >> + __u8 pad[6]; >> + __u64 serror_esr; >> + } exception; >> + __u32 reserved[12]; > > It will be easier to re-purpose this in the future if the field is > reserved and is checked that it must be zero. SET_VCPU_EVENTS would > return EINVAL if reserved fields get used until a later meaning is > defined for them. Ok, thanks. I will check the reserved fields when calling SET_VCPU_EVENTS. > >> +}; >> + >> /* If you need to interpret the index values, here is the key: */ >> #define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 >> #define KVM_REG_ARM_COPROC_SHIFT 16 >> diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c >> index 56a0260..71d3841 100644 >> --- a/arch/arm64/kvm/guest.c >> +++ b/arch/arm64/kvm/guest.c >> @@ -289,6 +289,42 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, >> return -EINVAL; >> } >> [...] >> -- >> 2.7.4 >> > > . >