From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7DA3624BCF5; Fri, 12 Sep 2025 16:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757692924; cv=none; b=p/RCKN2IrE/IGH6el974NphKhoQhWa2gI7c768EhgnnoN7w7zchafn4ZZYqWCKlVvAXqKRGJT3V6CukAP3hYAhzhVrcVt3qtSKecchOMyjPHGwvqaWFl26hT6geuat7daJBo+PGqdp/I177MRQRcbB5BV1knCKwGIOebSTkMQIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757692924; c=relaxed/simple; bh=Z2IP7ven87DpeGSpQzq3ec7cEllqPfB1tj/RViXsTzc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hDWZFSIk2NiFs0eFiunVa1YXHUPufy2oymKmV4ewX0G/2HE4KNzvqYi+oLqwngfct98//aunrPlbB/xX2nQ7h1KgHeDIe9/qnKsjK3VoWnc//7rzWiYqmUccyB1d31iUqTaopx6NVGVovoCGmwd3GDJEGgDllr4svlr6unQOfEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 801991515; Fri, 12 Sep 2025 09:01:53 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD4933F66E; Fri, 12 Sep 2025 09:01:56 -0700 (PDT) Message-ID: <2ed1be84-5097-488d-b8ce-7abebf5b9a7e@arm.com> Date: Fri, 12 Sep 2025 17:01:55 +0100 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 29/29] arm_mpam: Add kunit tests for props_mismatch() To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-30-james.morse@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20250910204309.20751-30-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi James, On 9/10/25 21:43, James Morse wrote: > When features are mismatched between MSC the way features are combined > to the class determines whether resctrl can support this SoC. > > Add some tests to illustrate the sort of thing that is expected to > work, and those that must be removed. > > Signed-off-by: James Morse > --- > Changes since v1: > * Waggled some words in comments. > * Moved a bunch of variables to be global - shuts up a compiler warning. > --- > drivers/resctrl/mpam_internal.h | 8 +- > drivers/resctrl/test_mpam_devices.c | 321 ++++++++++++++++++++++++++++ > 2 files changed, 328 insertions(+), 1 deletion(-) > Looks good to me, I checked the tests for v1. I agree with Jonathan that you could make RESET_FAKE_HIEARCHY() a function now that you've changed to use globals. Reviewed-by: Ben Horgan Thanks, Ben