public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Mark Gross <mgross@linux.intel.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: "open list:X86 PLATFORM DRIVERS" 
	<platform-driver-x86@vger.kernel.org>,
	markpearson@lenovo.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v4 0/3] Let other drivers react to platform profile changes
Date: Wed, 27 Oct 2021 15:51:45 +0200	[thread overview]
Message-ID: <2ef89421-a783-e1b2-0a31-1f2be5343e22@redhat.com> (raw)
In-Reply-To: <20211026190835.10697-1-mario.limonciello@amd.com>

Hi Mario,

On 10/26/21 21:08, Mario Limonciello wrote:
> Currently only one driver can register as a handler for a platform profile.
> 
> This limitation means that if multiple drivers want to react to platform
> profile changes that they will need to directly interact with individual
> drivers.
> 
> Instead introduce a notification flow that drivers can register for event
> changes.  The idea is that any driver that wants to can:
> 1. read the current profile
> 2. set up initial values
> 3. register for changes
> 4. react to changes
> 
> Changes from v3->v4:
>  * Simplify platform_profile_notify
>    - No need to check cur_profile as platform_profile_get does it
>    - No need to track ret as it's unused
> Changes from v2->v3:
>  * Add patches to avoid collisions in hp-wmi and asus-wmi symbols

We typically do not merge new in-kernel API without at least one
consumer of that in-kernel API.

I can take patches 1 + 2 now as prep work for the future,
but I would expect Rafael to only want to take patch 3/3 if
you post a new series which also includes at least one consumer
for the functionality added by 3/3.

That will also make it a lot easier to review 3/3 / to consider
other means to reach the same goal.
Rafael, do you concur?

Regards,

Hans


  parent reply	other threads:[~2021-10-27 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 19:08 [PATCH v4 0/3] Let other drivers react to platform profile changes Mario Limonciello
2021-10-26 19:08 ` [PATCH v4 1/3] platform/x86: hp-wmi: rename platform_profile_* function symbols Mario Limonciello
2021-10-27 14:08   ` Hans de Goede
2021-10-26 19:08 ` [PATCH v4 2/3] platform/x86: asus-wmi: " Mario Limonciello
2021-10-27 14:08   ` Hans de Goede
2021-10-26 19:08 ` [PATCH v4 3/3] ACPI: platform_profile: Add support for notification chains Mario Limonciello
2021-10-27 13:51 ` Hans de Goede [this message]
2021-10-27 13:57   ` [PATCH v4 0/3] Let other drivers react to platform profile changes Rafael J. Wysocki
2021-10-27 14:02     ` Limonciello, Mario

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ef89421-a783-e1b2-0a31-1f2be5343e22@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=markpearson@lenovo.com \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox