From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E2C8C48BE6 for ; Wed, 16 Jun 2021 14:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62EB361107 for ; Wed, 16 Jun 2021 14:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233882AbhFPOiS (ORCPT ); Wed, 16 Jun 2021 10:38:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32734 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232825AbhFPOiS (ORCPT ); Wed, 16 Jun 2021 10:38:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623854171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cIXwhCiivN2/2EEIJhW4aEymd94Mvvrv7X7NQrtq+U8=; b=H38XPICdGXQSPgYcYqJKuW0zClyKcE5KMs9n5QKcpA8vAHl0hpZaJawPYRBx79eR/jS53H NOPH8OgobYcYPeVqDNrw7y/URQJqEYz7NVZMI/2uAJFIWBOCi2neo9pZhDHVk36kCoR8vb EapUbSc48fcsRM7SL4szmVzZbC8J1MM= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-3VM0GIiqOUmT8xNXsXhGXA-1; Wed, 16 Jun 2021 10:36:10 -0400 X-MC-Unique: 3VM0GIiqOUmT8xNXsXhGXA-1 Received: by mail-ej1-f70.google.com with SMTP id z6-20020a17090665c6b02903700252d1ccso1037284ejn.10 for ; Wed, 16 Jun 2021 07:36:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cIXwhCiivN2/2EEIJhW4aEymd94Mvvrv7X7NQrtq+U8=; b=kcIo6P7aIgFCx2fiWvyR7t85S0gASAcFTJFOLF8MnbslFEwStdmTnlNksHcTwfcs/h dvMUP0vaB/SmP3duKKijnfL75NzBYiUpWauHGKjBw0na+i3rx5CA9VW/amc7Zclnlckm XxGrqLst23uizJV0EcHFVf+utLJmIiTwYA5ytv5C3AKR7AWEaBRfvTFyjR4YzcFOoJjS rg5ja3o5ofI5uJ6fM+f8V+ofy0gDgXFqLoG5ZOhUznNw95gf7uaV5I529coneHLbxsEk xVYf/Pb+9+/DWENMvZfdmRDePN1Gi9Ee5P0XVXx8IlTJdUBTuWw8SRNcQbiIITZFLFvz C4pg== X-Gm-Message-State: AOAM530AkkdZyGbuHhG85d53PXWu+/bcv0l95YyskNj1cX31bVl4z8st UwP/it5BP/kjnvhvx1j6yT25nsNkn1qu8Z5YAm/gGnswSH1Eigsbt+DM9yPiwH6wIFQ5WFopUko Bli55XUBu5qyUVZj907dZOA== X-Received: by 2002:a17:906:9516:: with SMTP id u22mr112331ejx.442.1623854168997; Wed, 16 Jun 2021 07:36:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPCD2JgYIR20tTh83PkrjX/7c8LpiFVshRDBld6FHse3iQ6bzc9TSeCNJzmqLnjQIIMBw6ag== X-Received: by 2002:a17:906:9516:: with SMTP id u22mr112325ejx.442.1623854168874; Wed, 16 Jun 2021 07:36:08 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id x3sm1734908ejw.69.2021.06.16.07.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 07:36:08 -0700 (PDT) Subject: Re: [PATCH 1/5] ACPI: scan: Rearrange acpi_dev_get_first_consumer_dev_cb() To: "Rafael J. Wysocki" , Linux ACPI Cc: LKML References: <3140195.44csPzL39Z@kreacher> <9924939.nUPlyArG6x@kreacher> From: Hans de Goede Message-ID: <308f4eb8-8a8b-2cb8-bf99-cc112e812f47@redhat.com> Date: Wed, 16 Jun 2021 16:36:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <9924939.nUPlyArG6x@kreacher> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 6/16/21 4:21 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Make acpi_dev_get_first_consumer_dev_cb() a bit more straightforward > and rewrite the comment in it. > > No functional impact. > > Signed-off-by: Rafael J. Wysocki Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/acpi/scan.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > Index: linux-pm/drivers/acpi/scan.c > =================================================================== > --- linux-pm.orig/drivers/acpi/scan.c > +++ linux-pm/drivers/acpi/scan.c > @@ -2107,13 +2107,12 @@ static int acpi_dev_get_first_consumer_d > struct acpi_device *adev; > > adev = acpi_bus_get_acpi_device(dep->consumer); > - if (!adev) > - /* If we don't find an adev then we want to continue parsing */ > - return 0; > - > - *(struct acpi_device **)data = adev; > - > - return 1; > + if (adev) { > + *(struct acpi_device **)data = adev; > + return 1; > + } > + /* Continue parsing if the device object is not present. */ > + return 0; > } > > static int acpi_scan_clear_dep(struct acpi_dep_data *dep, void *data) > > >