From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC1DEB64DD for ; Fri, 28 Jul 2023 07:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234425AbjG1HoM (ORCPT ); Fri, 28 Jul 2023 03:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234418AbjG1HoH (ORCPT ); Fri, 28 Jul 2023 03:44:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72B903592 for ; Fri, 28 Jul 2023 00:44:06 -0700 (PDT) Received: from [192.168.100.7] (unknown [59.103.217.95]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 76EBE660704F; Fri, 28 Jul 2023 08:44:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690530243; bh=5yC0SPVI3RI+4jj+ce7eMye7XQ5thMQfXfAF7lx7FLY=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=A73/1iYedZBvKV9gS3nqYCfwNqvpqBGdHDA/J8MIhhEi+bBLa2+nF0gPcEICTA427 dDVdIyZx98rtfd9oEPSnx182M/vS7sJdPW+e9zgrhQ2ck/sQNQMF05okPEZ4RcuiYA TknTu9TI9QX+qIQWxd50yvZ+mA9aLjkpY4nWdjXapgiOKtacmcUTjY0h6bqEcDkYQm JR3zNE6vwWeUsBdpZtNVuQCcUD5e+LsDEZ8Wj5IEqOLJIml53JLhoHXkdmyLJu95us M9r1D/Ntg3z+qmwBjan83uN53wZjv3zvtSYRo0EbcCaFikKnpdNmZX3ineu45Azyom ZoOizkHMdFWtw== Message-ID: <331b4f97-388c-046a-d8b4-dd5bd45c9557@collabora.com> Date: Fri, 28 Jul 2023 12:43:57 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Muhammad Usama Anjum , bleung@chromium.org, groeck@chromium.org, rafael@kernel.org, lenb@kernel.org, chrome-platform@lists.linux.dev, linux-acpi@vger.kernel.org, guillaume.tucker@collabora.com, denys.f@collabora.com, ricardo.canuelo@collabora.com Subject: Re: [PATCH] platform/chrome: chromeos_acpi: use official HID GOOG0016 Content-Language: en-US To: Tzung-Bi Shih References: <20230728014256.3836298-1-tzungbi@kernel.org> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 7/28/23 11:32 AM, Tzung-Bi Shih wrote: > On Fri, Jul 28, 2023 at 10:59:22AM +0500, Muhammad Usama Anjum wrote: >> On 7/28/23 6:42 AM, Tzung-Bi Shih wrote: >>> Use official HID GOOG0016 for ChromeOS ACPI (see [1]). >>> >>> [1]: https://crrev.com/c/2266713 >>> >>> Signed-off-by: Tzung-Bi Shih >>> --- >>> AFAIK, there has no ChromeOS devices using the driver yet. Instead, they >>> still stick to some downstream implementation. IOW, I guess we are safe >>> to just replace the PNP ID. >> GOOG0016 got introduced in newer firmware. Older firmware will still have >> only GGL0001 id. Lets keep both IDs otherwise the updated driver will not >> work on older chromebooks. This can be easily achieved by keeping both IDs >> in chromeos_device_ids. > > Thanks for the review. I overlooked the case. Will fix it in next version. > > So if I'm looking for the path, whether it bases on "GOOG0016" or "GGL0001", > it actually depends on what firmware the system has? So kernel will the match the firware's ID with list of IDs defined there. -- BR, Muhammad Usama Anjum