public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Veronika Kabatova <vkabatov@redhat.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Will Deacon <will@kernel.org>,
	CKI Project <cki-project@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Memory Management <mm-qe@redhat.com>,
	skt-results-master@redhat.com, Jeff Bastian <jbastian@redhat.com>,
	Jan Stancek <jstancek@redhat.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Hanjun Guo <guohanjun@huawei.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	lv.zheng@intel.com, Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>
Subject: Re: ❌ FAIL: Test report for kernel 5.13.0-rc7 (arm-next, 8ab9b1a9)
Date: Thu, 22 Jul 2021 14:51:43 +0100	[thread overview]
Message-ID: <3422218f-73cc-ed3d-025a-ccf809075968@arm.com> (raw)
In-Reply-To: <CA+tGwnmu-uL1v3vWO1yzH1i1ru6+EbVdEKnGOifoS6fLuTTGoQ@mail.gmail.com>

On 2021-07-22 13:38, Veronika Kabatova wrote:
> On Fri, Jul 16, 2021 at 6:26 PM Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
>>
>> On Fri, Jul 16, 2021 at 06:16:01PM +0200, Ard Biesheuvel wrote:
>>> On Mon, 5 Jul 2021 at 18:17, Lorenzo Pieralisi
>>> <lorenzo.pieralisi@arm.com> wrote:
>>>>
>>>> On Wed, Jun 30, 2021 at 08:18:22PM +0200, Ard Biesheuvel wrote:
>>>>
>>>> [...]
>>>>
>>>>>> In current code, even if the BERT were mapped with acpi_os_map_iomem()
>>>>>> this would change nothing since it's acpi_os_ioremap() that runs the
>>>>>> rule (backed up by EFI memory map region info).
>>>>>>
>>>>>
>>>>> Indeed. So the fact that acpi_os_map_memory() is backed by
>>>>> acpi_os_ioremap() is something we should fix. So they should both
>>>>> consult the EFI memory map, but have different fallback defaults if
>>>>> the region is not annotated correctly.
>>>>
>>>> Put together patch below even though I am not really satisfied, a tad
>>>> intrusive and duplicate code in generic/arch backends, compile tested
>>>> only; overall this IO vs memory mapping distinction is a bit too fuzzy
>>>> for my taste - there is legacy unfortunately to consider though.
>>>>
>>>
>>> I'd say that this does not look unreasonable at all. Is there any way
>>> we could get this tested on actual hw?
>>
>> Sure, I was meant to follow-up and was caught up in something else,
>> sorry.
>>
>> I will clean up the log, push it out in a branch on Monday, CKI
>> should pick it up. I will also think about other possible testing
>> options.
>>
> 
> Hi,
> 
> thanks for the patience with the testing, the stress-ng test couldn't
> deal with a new glibc version and had to be fixed and this week
> has just been crazy.
> 
> I managed to do 2 runs of the updated tree with the stress-ng test
> and it didn't hit the problem. Given how unreliably it reproduces it
> doesn't mean all that much. I still have one more run pending and
> can submit more if needed.
> 
> However, we ran into a panic with this tree on a completely
> different machine:
> 
> https://gitlab.com/-/snippets/2152899/raw/main/snippetfile1.txt

All the warnings from arch_setup_dma_ops() there are (unfortunately) 
pretty much legitimate for that platform, and should be gone again since 
rc2 with commit c1132702c71f.

> The machine also hit a hardware error during LTP:
> 
> https://gitlab.com/-/snippets/2152899/raw/main/snippetfile2.txt

Hmm, if "access mode: secure" in that fault report implies that the 
firmnware itself has done something dodgy to raise an SError, I'm not 
sure there's much we can do about that...

Robin.

  reply	other threads:[~2021-07-22 13:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cki.6A65B499FE.46BPQ6DJTC@redhat.com>
     [not found] ` <20210625083918.GA2736@willie-the-truck>
     [not found]   ` <CA+tGwn=rP_hAMLLtoy_s90ZzBjfMggu7T2Qj8HyFfGh1BGUoRA@mail.gmail.com>
     [not found]     ` <31ffe8fc-f5ee-2858-26c5-0fd8bdd68702@arm.com>
     [not found]       ` <20210625110944.GB20835@arm.com>
     [not found]         ` <48b23351-3dba-bec8-242f-3c918ae55708@arm.com>
2021-06-29 11:48           ` ❌ FAIL: Test report for kernel 5.13.0-rc7 (arm-next, 8ab9b1a9) Robin Murphy
2021-06-29 14:44             ` Lorenzo Pieralisi
2021-06-29 15:14               ` Robin Murphy
2021-06-29 16:35                 ` Catalin Marinas
2021-06-30 10:37                   ` Lorenzo Pieralisi
2021-06-30 11:17                     ` Robin Murphy
2021-06-30 13:22                       ` Ard Biesheuvel
2021-06-30 15:49                         ` Lorenzo Pieralisi
2021-06-30 18:18                           ` Ard Biesheuvel
2021-07-05 16:17                             ` Lorenzo Pieralisi
2021-07-16 16:16                               ` Ard Biesheuvel
2021-07-16 16:26                                 ` Lorenzo Pieralisi
2021-07-22 12:38                                   ` Veronika Kabatova
2021-07-22 13:51                                     ` Robin Murphy [this message]
2021-07-22 18:23                                       ` Veronika Kabatova
2021-06-29 17:03                 ` Veronika Kabatova
2021-06-29 17:27                   ` Robin Murphy
2021-06-29 17:44                     ` Veronika Kabatova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3422218f-73cc-ed3d-025a-ccf809075968@arm.com \
    --to=robin.murphy@arm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cki-project@redhat.com \
    --cc=guohanjun@huawei.com \
    --cc=james.morse@arm.com \
    --cc=jbastian@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lv.zheng@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=mm-qe@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=skt-results-master@redhat.com \
    --cc=sudeep.holla@arm.com \
    --cc=tony.luck@intel.com \
    --cc=vkabatov@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox