From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
To: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nvdimm@lists.linux.dev>,
"Williams, Dan J" <dan.j.williams@intel.com>
Cc: <rafael.j.wysocki@intel.com>, <andriy.shevchenko@intel.com>,
<lenb@kernel.org>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>
Subject: Re: [PATCH v1 0/2] Fix memory leak and move to modern scope based rollback
Date: Wed, 11 Oct 2023 16:14:55 +0200 [thread overview]
Message-ID: <348c239f-243e-405a-a0ee-92433626b682@intel.com> (raw)
In-Reply-To: <20230926184520.2239723-1-michal.wilczynski@intel.com>
On 9/26/2023 8:45 PM, Michal Wilczynski wrote:
> In acpi_nfit_init_interleave_set() there is a memory leak + improper use
> of devm_*() family of functions for local memory allocations. This patch
> series provides two commits - one is meant as a bug fix, and could
> potentially be backported, and the other one improves old style rollback
> with scope based, similar to C++ RAII [1].
>
> Link: https://lwn.net/Articles/934679/ [1]
>
> Michal Wilczynski (2):
> ACPI: NFIT: Fix memory leak, and local use of devm_*()
> ACPI: NFIT: Use modern scope based rollback
>
> drivers/acpi/nfit/core.c | 21 ++++++++-------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
Hi Dan,
Do you think this patchset is fine ? Would you like me to
change anything ?
Regards,
Michał
>
prev parent reply other threads:[~2023-10-11 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 18:45 [PATCH v1 0/2] Fix memory leak and move to modern scope based rollback Michal Wilczynski
2023-09-26 18:45 ` [PATCH v1 1/2] ACPI: NFIT: Fix memory leak, and local use of devm_*() Michal Wilczynski
2023-09-26 18:52 ` Dave Jiang
2023-10-02 9:37 ` Andy Shevchenko
2023-10-12 23:40 ` Dan Williams
2023-09-26 18:45 ` [PATCH v1 2/2] ACPI: NFIT: Use modern scope based rollback Michal Wilczynski
2023-09-26 18:50 ` Dave Jiang
2023-10-02 9:38 ` Andy Shevchenko
2023-10-11 14:14 ` Wilczynski, Michal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348c239f-243e-405a-a0ee-92433626b682@intel.com \
--to=michal.wilczynski@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rafael.j.wysocki@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox