From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
"rafael@kernel.org" <rafael@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"daniel.lezcano@kernel.org" <daniel.lezcano@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"amitk@kernel.org" <amitk@kernel.org>
Subject: Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points int340x
Date: Fri, 13 Jan 2023 07:48:59 -0800 [thread overview]
Message-ID: <34f9fc91c398f85c0bedaff89adbb33897cb1f62.camel@linux.intel.com> (raw)
In-Reply-To: <ddcfbd2e-2ea0-9305-96c4-8127181cdd8c@linaro.org>
Hi Daniel,
> > >
[...]
> > > - status = acpi_evaluate_integer(d->adev->handle, "GTSH",
> > > NULL,
> > > &hyst);
> > > - if (ACPI_FAILURE(status))
> > > - *temp = 0;
> > > - else
> > > - *temp = hyst * 100;
> >
> > The previous code returns hyst * 100.
> > But the new API retuurns hyst directly.
> >
> > -/sys/class/thermal/thermal_zone2/trip_point_4_hyst:2000
> > +/sys/class/the
> > rmal/thermal_zone2/trip_point_4_hyst:20
> >
> > Is this done on purpose?
>
> No, it is an error. The function thermal_acpi_trip_gtsh() should do:
>
> return deci_kelvin_to_millicelsius(hyst);
>
>
GTSH returns here in tenths of degree Kelvin. For example 15 means 1.5
degree K.
I would like to test your next series with thermald. If there is a
problem, it will break every distro.
Thanks,
Srinivas
>
>
next prev parent reply other threads:[~2023-01-13 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 15:17 [PATCH v4 0/3] Thermal ACPI APIs for generic trip points Daniel Lezcano
2023-01-10 15:17 ` [PATCH 1/3] thermal/acpi: Add ACPI trip point routines Daniel Lezcano
2023-01-10 15:17 ` [PATCH 2/3] thermal/drivers/intel: Use generic trip points for intel_pch Daniel Lezcano
2023-01-10 15:17 ` [PATCH 3/3] thermal/drivers/intel: Use generic trip points int340x Daniel Lezcano
2023-01-13 11:41 ` Zhang, Rui
2023-01-13 12:12 ` Daniel Lezcano
2023-01-13 15:48 ` srinivas pandruvada [this message]
2023-01-13 17:21 ` Daniel Lezcano
2023-01-13 17:34 ` srinivas pandruvada
2023-01-13 15:44 ` srinivas pandruvada
2023-01-11 11:52 ` [PATCH v4 0/3] Thermal ACPI APIs for generic trip points Daniel Lezcano
2023-01-11 14:49 ` Zhang, Rui
2023-01-11 15:01 ` Daniel Lezcano
2023-01-12 2:13 ` Zhang, Rui
2023-01-13 11:46 ` Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34f9fc91c398f85c0bedaff89adbb33897cb1f62.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=amitk@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).