From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Marcus Bergo <marcusbergo@gmail.com>,
mark.pearson@lenovo.com, linux-acpi@vger.kernel.org,
platform-driver-x86@vger.kernel.org, lenb@kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: EC: Fix CPU frequency limitation on AMD platforms after suspend/resume
Date: Mon, 28 Apr 2025 14:10:58 -0500 [thread overview]
Message-ID: <369d0a74-4d5d-40e9-aa87-86c7563cf019@amd.com> (raw)
In-Reply-To: <CAJZ5v0jS+gdHqW3pB1awZ7LHHWsFBQMp86tNwPMVBzOfot-sZw@mail.gmail.com>
On 4/28/2025 2:02 PM, Rafael J. Wysocki wrote:
> On Mon, Apr 28, 2025 at 8:23 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>> On 4/28/2025 4:51 AM, Marcus Bergo wrote:
>>> Yes, it does.
>>>
>>
>> OK thanks for confirming. Considering your finding with this patch
>> you've shared and knowing there is a timing dependency that delaying the
>> next s2idle cycle helps I do wonder if we should keep exploring.
>>
>> Rafael, do you have thoughts here? Specifically do you think it's worth
>> revisiting if b5539eb5ee70 was the correct move.
>
> Well, it was done for a reason that is explained in its changelog. I
> think that the problem addressed by it is genuine, isn't it?
>
I mean yes - of course. My inquiry was whether this should be the
default behavior or if it should have been a quirked behavior.
I don't have a good sense for the rest of the ecosystem what the impacts
would really be at flipping it. Would it be worth adding a module
parameter debug knob and survey what happens on a wide variety of machines?
next prev parent reply other threads:[~2025-04-28 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f5dd019ad4506.2100bf0f83374@gmail.com>
2025-04-19 9:28 ` [PATCH] ACPI: EC: Fix CPU frequency limitation on AMD platforms after suspend/resume M. Bergo
2025-04-19 18:03 ` Mario Limonciello
2025-04-24 14:11 ` Mario Limonciello
2025-04-27 18:34 ` M. Bergo
2025-04-28 2:06 ` Mario Limonciello
[not found] ` <CAJOrcgV-5tr66YbDd_mCL00YHg7nPVdJUon9Az7pZQXpNtwUoA@mail.gmail.com>
2025-04-28 18:23 ` Mario Limonciello
2025-04-28 19:02 ` Rafael J. Wysocki
2025-04-28 19:10 ` Mario Limonciello [this message]
2025-04-28 19:45 ` Rafael J. Wysocki
2025-04-28 21:06 ` Mario Limonciello
2025-04-27 18:37 ` M. Bergo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=369d0a74-4d5d-40e9-aa87-86c7563cf019@amd.com \
--to=mario.limonciello@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcusbergo@gmail.com \
--cc=mark.pearson@lenovo.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox