From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [update][PATCH v10 06/21] ACPI / sleep: Introduce CONFIG_ACPI_GENERIC_SLEEP Date: Tue, 17 Mar 2015 03:28:37 +0100 Message-ID: <3737028.Ib0fKlgSkd@vostro.rjw.lan> References: <1426234469-6434-1-git-send-email-hanjun.guo@linaro.org> <5704037.pUGdJ0Q9hF@vostro.rjw.lan> <55077E9D.50103@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:53772 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751530AbbCQCEq convert rfc822-to-8bit (ORCPT ); Mon, 16 Mar 2015 22:04:46 -0400 In-Reply-To: <55077E9D.50103@huawei.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo Cc: Hanjun Guo , Catalin Marinas , Will Deacon , Olof Johansson , Grant Likely , Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , Graeme Gregory , Sudeep Holla , Jon Masters , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , suravee.suthikulpanit@amd.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Tomasz Nowicki On Tuesday, March 17, 2015 09:08:45 AM Hanjun Guo wrote: > On 2015/3/17 7:15, Rafael J. Wysocki wrote: > > On Monday, March 16, 2015 08:14:52 PM Hanjun Guo wrote: > >> On 2015=E5=B9=B403=E6=9C=8814=E6=97=A5 05:49, Rafael J. Wysocki wr= ote: > >>> On Friday, March 13, 2015 04:14:29 PM Hanjun Guo wrote: > [...] > >>>> > >>>> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > >>>> index 074e52b..e8728d7 100644 > >>>> --- a/arch/ia64/Kconfig > >>>> +++ b/arch/ia64/Kconfig > >>>> @@ -10,6 +10,7 @@ config IA64 > >>>> select ARCH_MIGHT_HAVE_PC_SERIO > >>>> select PCI if (!IA64_HP_SIM) > >>>> select ACPI if (!IA64_HP_SIM) > >>>> + select ACPI_GENERIC_SLEEP if ACPI > >>>> select ARCH_MIGHT_HAVE_ACPI_PDC if ACPI > >>>> select HAVE_UNSTABLE_SCHED_CLOCK > >>>> select HAVE_IDE > >>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > >>>> index b7d31ca..9804431 100644 > >>>> --- a/arch/x86/Kconfig > >>>> +++ b/arch/x86/Kconfig > >>>> @@ -22,6 +22,7 @@ config X86_64 > >>>> ### Arch settings > >>>> config X86 > >>>> def_bool y > >>>> + select ACPI_GENERIC_SLEEP if ACPI > >>> One more nit. If you did > >>> > >>> + select ACPI_GENERIC_SLEEP if ACPI_SLEEP > >>> > >>> here (and above for ia64), you'd avoid having to make ACPI_SLEEP > >>> depend on ACPI_GENERIC_SLEEP which goes somewhat backwards. > >> In sleep.c, > >> > >> #ifdef CONFIG_ACPI_SLEEP > >> acpi_target_system_state() > >> { > >> } > >> #endif > >> > >> and CONFIG_ACPI_SLEEP depends on SUSPEND || HIBERNATION, > >> which one of them will be enabled on ARM64 so ACPI_SLEEP > >> will also enabled too. > >> > >> So if we > >> > >> +select ACPI_GENERIC_SLEEP if ACPI_SLEEP > >> > >> and > >> > >> +acpi-$(CONFIG_ACPI_GENERIC_SLEEP) +=3D sleep.o > >> > >> it will lead to errors for acpi_target_system_state() that > >> is declared but not defined, so I will keep the code as > >> it is, what do you think? > > No, we need to hash this out. Having two different Kconfig options= meaning > > almost the same thing (ACPI_SLEEP and ACPI_GENERIC_SLEEP) is beyond= ugly. > > > > Do you need ACPI_SLEEP on ARM64 at all? >=20 > No, at least for now we don't need it, the spec for sleep is not read= y for > ARM64 arch, so ACPI_SLEEP will not work at all on ARM64. Well, so what about selecting ACPI_SLEEP from the architectures that us= e it? --=20 I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html