From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Dumbre, Saket" <saket.dumbre@intel.com>
Subject: [PATCH v1 09/16] ACPICA: dispatcher: Use acpi_ds_clear_operands() in acpi_ds_call_control_method()
Date: Fri, 12 Sep 2025 22:00:17 +0200 [thread overview]
Message-ID: <3848043.MHq7AAxBmi@rafael.j.wysocki> (raw)
In-Reply-To: <2021361.PYKUYFuaPT@rafael.j.wysocki>
From: Hans de Goede <hansg@kernel.org>
When deleting the previous walkstate operand stack
acpi_ds_call_control_method() was deleting obj_desc->Method.param_count
operands. But Method.param_count does not necessarily match
this_walk_state->num_operands, it may be either less or more.
After correcting the for loop to check `i < this_walk_state->num_operands`
the code is identical to acpi_ds_clear_operands(), so just outright
replace the code with acpi_ds_clear_operands() to fix this.
Link: https://github.com/acpica/acpica/commit/53fc0220
Signed-off-by: Hans de Goede <hansg@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/acpica/dsmethod.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/acpi/acpica/dsmethod.c b/drivers/acpi/acpica/dsmethod.c
index fef6fb29ece4..e707a7036802 100644
--- a/drivers/acpi/acpica/dsmethod.c
+++ b/drivers/acpi/acpica/dsmethod.c
@@ -546,14 +546,7 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
* Delete the operands on the previous walkstate operand stack
* (they were copied to new objects)
*/
- for (i = 0; i < obj_desc->method.param_count; i++) {
- acpi_ut_remove_reference(this_walk_state->operands[i]);
- this_walk_state->operands[i] = NULL;
- }
-
- /* Clear the operand stack */
-
- this_walk_state->num_operands = 0;
+ acpi_ds_clear_operands(this_walk_state);
ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
"**** Begin nested execution of [%4.4s] **** WalkState=%p\n",
--
2.51.0
next prev parent reply other threads:[~2025-09-12 20:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 19:51 [PATCH v1 00/16] ACPICA: ACPICA 20250807 Rafael J. Wysocki
2025-09-12 19:52 ` [PATCH v1 01/16] ACPICA: Modify variable definition position Rafael J. Wysocki
2025-09-12 19:53 ` [PATCH v1 02/16] ACPICA: Remove redundant "#ifdef" definitions Rafael J. Wysocki
2025-09-12 19:54 ` [PATCH v1 03/16] ACPICA: Change the compilation conditions Rafael J. Wysocki
2025-09-12 19:54 ` [PATCH v1 04/16] ACPICA: Allow to skip Global Lock initialization Rafael J. Wysocki
2025-09-12 19:55 ` [PATCH v1 05/16] ACPICA: Apply ACPI_NONSTRING Rafael J. Wysocki
2025-09-12 19:56 ` [PATCH v1 06/16] ACPICA: iASL: Fix printing CDAT table header Rafael J. Wysocki
2025-09-12 19:58 ` [PATCH v1 07/16] ACPICA: acpidump: drop ACPI_NONSTRING attribute from file_name Rafael J. Wysocki
2025-09-12 19:59 ` [PATCH v1 08/16] ACPICA: Debugger: drop ACPI_NONSTRING attribute from name_seg Rafael J. Wysocki
2025-09-12 20:00 ` Rafael J. Wysocki [this message]
2025-09-12 20:01 ` [PATCH v1 10/16] ACPICA: Update dsmethod.c to get rid of unused variable warning Rafael J. Wysocki
2025-09-12 20:01 ` [PATCH v1 11/16] ACPICA: Print error messages for too few or too many arguments Rafael J. Wysocki
2025-09-12 20:02 ` [PATCH v1 12/16] ACPICA: Update version to 20250807 Rafael J. Wysocki
2025-09-12 20:03 ` [PATCH v1 13/16] ACPICA: Fix largest possible resource descriptor index Rafael J. Wysocki
2025-09-12 20:04 ` [PATCH v1 14/16] ACPICA: CEDT: Add Back-Invalidate restriction to CXL Window Rafael J. Wysocki
2025-09-12 20:05 ` [PATCH v1 15/16] ACPICA: ACPI_TYPE_ANY does not include the package type Rafael J. Wysocki
2025-09-12 20:06 ` [PATCH v1 16/16] ACPICA: acpidump: fix return values in ap_is_valid_checksum() Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3848043.MHq7AAxBmi@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saket.dumbre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox