From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI: event: replace strcpy() by strscpy() Date: Wed, 01 May 2019 12:12:35 +0200 Message-ID: <3853797.yZSUUGEqGl@kreacher> References: <20190422163934.GA2636@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190422163934.GA2636@embeddedor> Sender: linux-kernel-owner@vger.kernel.org To: "Gustavo A. R. Silva" Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Monday, April 22, 2019 6:39:34 PM CEST Gustavo A. R. Silva wrote: > The strcpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warnings: > > "You might overrun the 15-character fixed-size string event->bus_id > by copying bus_id without checking the length." > > "You might overrun the 20-character fixed-size string event->device_class > by copying device_class without checking the length." > > Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/acpi/event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c > index 5a127f3f2d5c..47f21599f2ab 100644 > --- a/drivers/acpi/event.c > +++ b/drivers/acpi/event.c > @@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class, > event = nla_data(attr); > memset(event, 0, sizeof(struct acpi_genl_event)); > > - strcpy(event->device_class, device_class); > - strcpy(event->bus_id, bus_id); > + strscpy(event->device_class, device_class, sizeof(event->device_class)); > + strscpy(event->bus_id, bus_id, sizeof(event->bus_id)); > event->type = type; > event->data = data; > > Applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF44EC43219 for ; Wed, 1 May 2019 10:12:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92BD421734 for ; Wed, 1 May 2019 10:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725959AbfEAKMj (ORCPT ); Wed, 1 May 2019 06:12:39 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:59252 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfEAKMi (ORCPT ); Wed, 1 May 2019 06:12:38 -0400 Received: from 79.184.254.69.ipv4.supernova.orange.pl (79.184.254.69) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id 71a593e25621d482; Wed, 1 May 2019 12:12:36 +0200 From: "Rafael J. Wysocki" To: "Gustavo A. R. Silva" Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI: event: replace strcpy() by strscpy() Date: Wed, 01 May 2019 12:12:35 +0200 Message-ID: <3853797.yZSUUGEqGl@kreacher> In-Reply-To: <20190422163934.GA2636@embeddedor> References: <20190422163934.GA2636@embeddedor> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190501101235.fVfkYZ9phoYr2EPMaqikH958tDnACWyOflFapoZCPos@z> On Monday, April 22, 2019 6:39:34 PM CEST Gustavo A. R. Silva wrote: > The strcpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warnings: > > "You might overrun the 15-character fixed-size string event->bus_id > by copying bus_id without checking the length." > > "You might overrun the 20-character fixed-size string event->device_class > by copying device_class without checking the length." > > Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/acpi/event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c > index 5a127f3f2d5c..47f21599f2ab 100644 > --- a/drivers/acpi/event.c > +++ b/drivers/acpi/event.c > @@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class, > event = nla_data(attr); > memset(event, 0, sizeof(struct acpi_genl_event)); > > - strcpy(event->device_class, device_class); > - strcpy(event->bus_id, bus_id); > + strscpy(event->device_class, device_class, sizeof(event->device_class)); > + strscpy(event->bus_id, bus_id, sizeof(event->bus_id)); > event->type = type; > event->data = data; > > Applied, thanks!