From: Thomas Renninger <trenn@suse.de>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
Tang Chen <tangchen@cn.fujitsu.com>,
Toshi Kani <toshi.kani@hp.com>, Len Brown <len.brown@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, ACPI: Increase override tables number limit
Date: Mon, 09 Sep 2013 15:25:31 +0200 [thread overview]
Message-ID: <3912512.hYKBVDmhoN@skinner.arch.suse.de> (raw)
In-Reply-To: <1378519680-10490-1-git-send-email-yinghai@kernel.org>
Hi,
I do not have a problem with this, just for info:
On Friday, September 06, 2013 07:08:00 PM Yinghai Lu wrote:
> Current acpi tables in initrd is limited to 10, that is too small.
> 64 should be good enough as we have 35 sigs and could have several
> SSDT.
The whole mechanism is for debugging only. Nobody would (or should,
there simply is no use case), override all the ACPI tables.
You would either override the APIC table if you try with interrupt
assignments. Or correct a part in the DSDT and/or SSDT(s) and check if the
kernel runs smoothly without errors then, etc.
>
> Two problems in current code prevent us from increasing limit:
> 1. that cpio file info array is put in stack, as every element is 32
> bytes, could run out of stack if we have that array size to 64.
> We can move it out from stack, and make it as global and put it in
> __initdata section.
> 2. early_ioremap only can remap 256k one time. Current code is mapping
> 10 tables one time. If we increase that limit, whole size could be
> more than 256k, early_ioremap will fail with that.
> We can map chunks one by one during copying, instead of mapping
> all them one time.
This problem would persist, because the by far biggest table typically
is the DSDT with several ten thousand lines of code, while the other
tables typically only have some hundred.
Thomas
next prev parent reply other threads:[~2013-09-09 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-07 2:08 [PATCH] x86, ACPI: Increase override tables number limit Yinghai Lu
2013-09-07 22:08 ` Rafael J. Wysocki
2013-09-09 14:49 ` H. Peter Anvin
2013-09-09 13:25 ` Thomas Renninger [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-15 5:58 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3912512.hYKBVDmhoN@skinner.arch.suse.de \
--to=trenn@suse.de \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tangchen@cn.fujitsu.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox