public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@kernel.org>
To: "Schmauss, Erik" <erik.schmauss@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	Len Brown <lenb@kernel.org>,
	"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
	<devel@acpica.org>, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when CONFIG_PCI is unset
Date: Wed, 12 Dec 2018 14:34:27 -0500	[thread overview]
Message-ID: <39dc076f-1b3d-ad0c-c4bb-056ac589f361@kernel.org> (raw)
In-Reply-To: <CF6A88132359CE47947DB4C6E1709ED53C556B2C@ORSMSX122.amr.corp.intel.com>

On 12/12/2018 2:02 PM, Schmauss, Erik wrote:
>> ++ b/drivers/acpi/acpica/achware.h
>> @@ -109,8 +109,17 @@ acpi_hw_enable_runtime_gpe_block(struct
>> acpi_gpe_xrupt_info *gpe_xrupt_info,
> CONFIG_PCI is a Linux-ism. We should stay with the OS-independent nature of
> ACPICA. Please use ACPI_PCI_CONFIGURED and put it above the comment like so:
> 
> #ifdef ACPI_PCI_CONFIGURED

Thanks for the feedback. My search for ACPI_PCI_CONFIGURED returned nothing.

git grep ACPI_PCI_CONFIGURED

@Rafael,

How do you want to handle this?

  reply	other threads:[~2018-12-12 19:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181212171941.7437-1-okaya@kernel.org>
2018-12-12 17:19 ` [PATCH v6 1/5] ACPI: Allow CONFIG_PCI to be unset for reboot Sinan Kaya
2018-12-12 17:19 ` [PATCH v6 2/5] ACPI / OSL: Stub out acpi_os_read_pci_configuration when CONFIG_PCI is unset Sinan Kaya
2018-12-12 17:19 ` [PATCH v6 3/5] ACPI / OSL: Stub out acpi_os_write_pci_configuration " Sinan Kaya
2018-12-12 17:19 ` [PATCH v6 4/5] PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set Sinan Kaya
2018-12-12 17:19 ` [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when CONFIG_PCI is unset Sinan Kaya
2018-12-12 19:02   ` Schmauss, Erik
2018-12-12 19:34     ` Sinan Kaya [this message]
2018-12-12 21:06       ` Rafael J. Wysocki
2018-12-12 21:16         ` Schmauss, Erik
2018-12-12 21:31           ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39dc076f-1b3d-ad0c-c4bb-056ac589f361@kernel.org \
    --to=okaya@kernel.org \
    --cc=devel@acpica.org \
    --cc=erik.schmauss@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox