From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Belmonte Subject: Re: More seq-file fixes for /proc/acpi Date: Fri, 14 Feb 2003 16:18:46 -0500 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <3E4D5D36.4080100@prairienet.org> References: <20030213223900.GA141@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20030213223900.GA141-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: acpi-devel Cc: Pavel Machek List-Id: linux-acpi@vger.kernel.org Pavel Machek wrote: > More seq-file fixes. [This is not a dup ;-)] Toshiba maintainer, > please fix your stuff yourself. This should fix all /proc write > problems in acpi I know... Please apply, > --- clean/drivers/acpi/toshiba_acpi.c 2003-02-11 17:40:46.000000000 +0100 > +++ linux/drivers/acpi/toshiba_acpi.c 2003-02-13 23:17:16.000000000 +0100 > @@ -519,6 +519,7 @@ > if (proc) { > proc->proc_fops = &toshiba_lcd_fops; > proc->proc_fops->write = proc_write_lcd; > +#warning You need to fix up after converting to seq_file; see thermal.c for examples. > } > > proc = create_proc_entry(PROC_VIDEO, S_IFREG | S_IRUGO | S_IWUSR, > I take exception to this. The person who converted my driver to seq_file should be responsible for finishing the job. I disagreed with the conversion to seq_file because it doesn't support an object oriented programming style, as I explained in a posting at the time the conversion took place. -John -- http:// if l . / ------------------------------------------------------- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en