acpi=off & /proc entries

["Zdeněk OGAR Skalák" <skalak-Bh/+Xfn7orxQjibfaplwYw@public.gmane.org>]

Hi,

	I'm using kernel 2.4.20 with ACPI version 20021205 (with additional patch as:
custom corrected DSDT, DSDT in initrd, \_OS override, .....). I find out a small
bug:
	if you boot with acpi=off argument, acpi isn't activated (as you would expect),
but proc-entries in /proc/acpi (as battery & so on), appears just below /proc
:-{

cat /var/log/dmesg:
...
ACPI: Subsystem revision 20021205
ACPI: Disabled via command line (acpi=off)
...
acpi_button-0466 [0001] [02] acpi_button_init      : ----Entry
acpi_bus-1247 [0001] [03] acpi_bus_register_driv: ----Entry
acpi_bus-1259 [0001] [03] acpi_bus_register_driv: ----Exit- 0000000000000000
acpi_button-0478 [0001] [02] acpi_button_init      : ----Exit- 0000000000000000
...

Reason:
	there's global struct proc_dir_entry *acpi_root_dir in bus.c 
	if you boot with acpi=off, it has it's implicit value of NULL
	all drivers (ex. button) has their init functions with this sequence:
		acpi_xxx_dir = proc_mkdir(ACPI_xxx_CLASS, acpi_root_dir); 
		// this success, (but acpi_root_dir==NULL :-{
		result = acpi_bus_register_driver(&acpi_xxx_driver);	
		// this returns 0, should it ?
		if (result<0){
			// we don't get here
			remove_proc_entry(ACPI_xxx_CLASS, acpi_root_dir);
			return_VALUE(-ENODEV);
		}
		return_VALUE(0);

	I think, we should (in each such driver) test the acpi_disabled variable & if
it's on, don't even bother with mkdir, register_bus_driver  .... Or don't allow
acpi_bus_register_driver to return success if acpi==off (test of acpi_disabled
there :-)

	Sorry, but don't have time (and even not the correct kernel tree & correct acpi
version) to make patch ...

	Bye
		Zdenek OGAR Skalak

-- 
Ing. Zdeněk OGAR Skalák
Monet+ a.s.
Zámecká 365
763 14 Zlín - Štípa, CZ
Tel: +420 / 577 110 411,  Fax: +420 / 577 914 557


-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
The only event dedicated to issues related to Linux enterprise solutions
www.enterpriselinuxforum.com