Re: Asus ACPI Hotkeys

[John Belmonte <jvb-ZFKsivP1bGvOQU1ULcgDhA@public.gmane.org>]

Julien Lerouge wrote:
> Well, here is a new version of the driver. It was tested against
> 2.4.21-rc2 + acpi-20030512-2.4.21-rc2.diff
> 
> Any comment welcome

Hi Julien,

Just a few suggestions about your copyright and credits:

You should remove Jonathan Buzzard from the copyright, since he didn't write any 
of the code.

You don't have to keep my copyright since I don't really see much of my code 
left, maybe just give me a credit if you'd like.  (If you keep it, it should be 
on a separate line so people know it is a derived work rather than co-authored.)

Perhaps you should remove the credits I wrote (Jonathan Buzzard, Yasushi 
Nagato), since they have no bearing on your current code.

Regards,
-John



-- 
http:// if   l .o  /



-------------------------------------------------------
This SF.net email is sponsored by: If flattening out C++ or Java
code to make your application fit in a relational database is painful, 
don't do it! Check out ObjectStore. Now part of Progress Software.
http://www.objectstore.net/sourceforge