public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex_williamson-VXdhtT5mjnY@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] Check for X__DSDT in acpi_get_table_header_early()
Date: Thu, 07 Aug 2003 15:14:25 -0600	[thread overview]
Message-ID: <3F32C131.50A997BA@hp.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]


   I finally got tired of my rx2600 printing garbage at the end of
the list of ACPI tables so I decided to fix it.  Turns out the HP
rx2600 does not provide a DSDT in the FADT, so we were trying to
print a table at 0x0.  It does provide a X_DSDT.  This patch will
make acpi_get_table_header_early() prefer the X_DSDT over the DSDT
and adds more checking for null.  Looks like the same code is in
2.6 and 2.4, please apply for both.  Thanks,

	Alex
 
-- 
Alex Williamson                             HP Linux & Open Source Lab

[-- Attachment #2: xdsdt.diff --]
[-- Type: text/plain, Size: 886 bytes --]

--- linux/drivers/acpi/tables.c	2003-07-27 11:00:40.000000000 -0600
+++ linux/drivers/acpi/tables.c	2003-08-07 14:15:11.000000000 -0600
@@ -256,10 +256,17 @@
 
 	/* Map the DSDT header via the pointer in the FADT */
 	if (id == ACPI_DSDT) {
-		struct acpi_table_fadt *fadt = (struct acpi_table_fadt *) *header;
+		struct fadt_descriptor_rev2 *fadt = (struct fadt_descriptor_rev2 *) *header;
+
+		if (fadt->header.revision == 3 && fadt->Xdsdt) {
+			*header = (void *) __acpi_map_table(fadt->Xdsdt,
+					sizeof(struct acpi_table_header));
+		} else if (fadt->V1_dsdt) {
+			*header = (void *) __acpi_map_table(fadt->V1_dsdt,
+					sizeof(struct acpi_table_header));
+		} else
+			*header = 0;
 
-		*header = (void *) __acpi_map_table(fadt->dsdt_addr,
-				sizeof(struct acpi_table_header));
 		if (!*header) {
 			printk(KERN_WARNING PREFIX "Unable to map DSDT\n");
 			return -ENODEV;

                 reply	other threads:[~2003-08-07 21:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F32C131.50A997BA@hp.com \
    --to=alex_williamson-vxdhtt5mjny@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox