[PATCH] ACPI pci irq routing fix

[PATCH] ACPI pci irq routing fix

[Chris Wright]

If irq.active is set from _CRS, make sure to use it, rather than trying
anything from the from the _PRS list, as some machines don't handle this
properly.  This patch is against current linux-acpi-test-2.6.0.  It's
been floating about for a while, and fixes bug #1186.

Patch originally from Andrew de Quincey.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

===== drivers/acpi/pci_link.c 1.19 vs edited =====
--- 1.19/drivers/acpi/pci_link.c	Thu Sep 18 11:29:36 2003
+++ edited/drivers/acpi/pci_link.c	Fri Sep 26 14:36:15 2003
@@ -500,15 +500,15 @@
 		irq = link->irq.active;
 	} else {
 		irq = link->irq.possible[0];
-	}
 
-	/* 
-	 * Select the best IRQ.  This is done in reverse to promote 
-	 * the use of IRQs 9, 10, 11, and >15.
-	 */
-	for (i=(link->irq.possible_count-1); i>0; i--) {
-		if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
-			irq = link->irq.possible[i];
+		/*
+		 * Select the best IRQ.  This is done in reverse to promote
+		 * the use of IRQs 9, 10, 11, and >15.
+		 */
+		for (i=(link->irq.possible_count-1); i>0; i--) {
+			if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
+				irq = link->irq.possible[i];
+		}
 	}
 
 	/* Attempt to enable the link device at this IRQ. */

Re: [PATCH] ACPI pci irq routing fix

[Nick Piggin]

Chris Wright wrote:

>If irq.active is set from _CRS, make sure to use it, rather than trying
>anything from the from the _PRS list, as some machines don't handle this
>properly.  This patch is against current linux-acpi-test-2.6.0.  It's
>been floating about for a while, and fixes bug #1186.
>
>Patch originally from Andrew de Quincey.
>
>thanks,
>-chris
>

This fixes my bug #1257.

Re: [PATCH] ACPI pci irq routing fix

[Len Brown]

On Sat, 2003-09-27 at 01:54, Nick Piggin wrote:
> Chris Wright wrote:
> 
> >If irq.active is set from _CRS, make sure to use it
...
> and fixes bug #1186.
> >
> >Patch originally from Andrew de Quincey.
> >
> 
> This fixes my bug #1257.
> 

This fix has been integrated with others in the ACPI patch,
and is available now in these bitkeeper trees:

http://linux-acpi.bkbits.net/linux-acpi-test-2.4.22
http://linux-acpi.bkbits.net/linux-acpi-test-2.4.23
http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0

It is also available as a plain patch "acpi_pci_link_allocate" here:

ftp.kernel.org:/pub/linux/kernel/people/lenb/acpi/patches/test/*

thanks,
-Len

Re: [PATCH] ACPI pci irq routing fix

[Chris Wright]

* Len Brown (len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org) wrote:
> 
> This fix has been integrated with others in the ACPI patch,
> and is available now in these bitkeeper trees:

Great, thanks Len.
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net