From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menage Subject: Re: ACPI global lock macros Date: Tue, 09 Dec 2003 11:04:05 -0800 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <3FD61CA5.6050203@google.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: "Grover, Andrew" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Grover, Andrew wrote: > > BTW, i386, x86_64 and ia64 all have this macro, so these all might need > to be looked at. > Yes, it was the differences between the i386 and x86_64 versions that made me notice this problem. The ia64 version is in C, so looks safer. Ideally there would be a common C definition - the only arch-specific part should be the locked cmpxchg, unless this lock is likely to be taken/released so often that it's performance critical. Paul ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/