Re: [RFC PATCH 1/1] ACPI / PMIC: Add i2c address to intel_pmic_bytcrc driver

Andy Shevchenko
2021-10-18T10:32:45Z

On Mon, Oct 18, 2021 at 12:16 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 10/17/21 18:15, Tsuchiya Yuto wrote:
> > On Microsoft Surface 3 (uses Intel's Atom Cherry Trail SoC), executing

...

> As Andy said we could use a DMI quirk for this, but chances are that the Microsoft Surface
> DSDT is not the only one with the wrong HRV value. So instead it might be better to
> just test for the SoC type as the attached patch does.
>
> Tsuchiya, can you give the attached patch a try.
>
> Andy, what do you think, should we go with the attached patch or would you prefer using
> a DMI quirk ?

TBH I have no strong opinion. Only one remark on your patch, I am not
a fan of removing COMPILE_TEST but at the same time I'm not a fan of
ifdeffery. All on all I think having COMPILE_TEST is preferable even
if we have ifdeffery. Btw, IIRC similar code (i.e. BYT vs CHT by CPU
ID) is being used elsewhere. Perhaps we might have some common
(library) under arc/x86, PDx86 or so (headers?)?

--
With Best Regards,
Andy Shevchenko