From: Mathias Nyman <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Sam Bobroff <sbobroff-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Russell Currey <ruscur-3Su/lFKaw5ejKv3TNrM5DQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vinod Koul <vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
jroedel-l3A5Bk7waGM@public.gmane.org,
oohall-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/6] xhci: Use device_iommu_mapped()
Date: Mon, 17 Dec 2018 13:21:43 +0200 [thread overview]
Message-ID: <3d5b3bb3-b119-7798-4c26-910782ef1bdf@linux.intel.com> (raw)
In-Reply-To: <20181211134343.10664-6-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On 11.12.2018 15:43, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
>
> Replace the dev->iommu_group check with a proper function
> call that better reprensents its purpose.
>
> Cc: Mathias Nyman <mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Acked-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> Signed-off-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dae3be1b9c8f..8eacd2ed412b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -244,7 +244,7 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
> * an iommu. Doing anything when there is no iommu is definitely
> * unsafe...
> */
> - if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !dev->iommu_group)
> + if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
> return;
>
> xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
>
Acked-by: Mathias Nyman <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
next prev parent reply other threads:[~2018-12-17 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 13:43 [PATCH 0/6 v2] Introduce device_iommu_mapped() function Joerg Roedel
[not found] ` <20181211134343.10664-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-11 13:43 ` [PATCH 1/6] driver core: " Joerg Roedel
[not found] ` <20181211134343.10664-2-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-11 14:59 ` Sergei Shtylyov
[not found] ` <b1344a34-cd5f-f080-fddf-c1548f85af6a-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2018-12-11 15:18 ` Joerg Roedel
2018-12-12 11:04 ` Greg Kroah-Hartman
2018-12-12 11:07 ` Joerg Roedel
2018-12-17 6:11 ` Vinod Koul
2018-12-17 9:31 ` Joerg Roedel
2018-12-11 13:43 ` [PATCH 3/6] ACPI/IORT: Use device_iommu_mapped() Joerg Roedel
2018-12-17 9:21 ` Hanjun Guo
2018-12-11 13:43 ` [PATCH 4/6] powerpc/iommu: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 2/6] iommu/of: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 5/6] xhci: " Joerg Roedel
[not found] ` <20181211134343.10664-6-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-17 11:21 ` Mathias Nyman [this message]
2018-12-11 13:43 ` [PATCH 6/6] dmaengine: sh: rcar-dmac: " Joerg Roedel
2018-12-17 6:11 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d5b3bb3-b119-7798-4c26-910782ef1bdf@linux.intel.com \
--to=mathias.nyman-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
--cc=oohall-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=ruscur-3Su/lFKaw5ejKv3TNrM5DQ@public.gmane.org \
--cc=sbobroff-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox