preparing toshiba_acpi driver release

preparing toshiba_acpi driver release

[John Belmonte]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Len,

I'm preparing a new release of the toshiba_acpi driver.  Below is the
tentative changelog.  I haven't been following the check-in policy of
the kernel or acpi subsystem lately, so I'm wondering if I can give this
to you as a single patch or do you need it in several parts.


~  * Fix remote chance of invalid buffer access in write_video.

~  * Support alternate HCI method path (recent "Phoenix BIOS" Toshiba's).

~  * Report more proc-write errors.

~  * On proc-reads, report errors via printk instead of proc output.

~  * Add level to all printk's.

~  * Add missing __init and __exit function attributes.


Regards,
- -John Belmonte


- --
http:// if  ile.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAFUE35Nfg6kxAQQoRAjQaAKCsdt8QoBH6w2TbtyPSzfpEy1ywMACguflq
cc6Z79zaEhCmj4C9USs5TBE=
=oq55
-----END PGP SIGNATURE-----


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

RE: preparing toshiba_acpi driver release

[Brown, Len]

Hi John,
In general, it it is best to have smaller patches which are single
logical changes so that they can be reviewed as a unit, tested as a
unit, and applied or un-applied as a unit.  However, if the changes are
small, grouping several together is fine.

Also, if the patch applies both to 2.4 and 2.6, but the patch is
different, then I appresiate getting both patches rather than having to
port the patch myself.

Note that the strategy going forward is to create a generic acpi/video
extensions driver that works on all platforms.  When it is available, we
should remove the video functionality from toshiba_extras and
asus_extras.
http://bugzilla.kernel.org/show_bug.cgi?id=1944

If anybody is excited about doing this, I'd be happy to work with a
volunteer.

Thanks,
-Len


> -----Original Message-----
> From: John Belmonte [mailto:john-wanGne27zNesTnJN9+BGXg@public.gmane.org] 
> Sent: Monday, January 26, 2004 11:33 AM
> To: Brown, Len
> Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: preparing toshiba_acpi driver release
> 
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello Len,
> 
> I'm preparing a new release of the toshiba_acpi driver.  Below is the
> tentative changelog.  I haven't been following the check-in policy of
> the kernel or acpi subsystem lately, so I'm wondering if I 
> can give this
> to you as a single patch or do you need it in several parts.
> 
> 
> ~  * Fix remote chance of invalid buffer access in write_video.
> 
> ~  * Support alternate HCI method path (recent "Phoenix BIOS" 
> Toshiba's).
> 
> ~  * Report more proc-write errors.
> 
> ~  * On proc-reads, report errors via printk instead of proc output.
> 
> ~  * Add level to all printk's.
> 
> ~  * Add missing __init and __exit function attributes.
> 
> 
> Regards,
> - -John Belmonte
> 
> 
> - --
> http:// if  ile.org/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.3 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
> 
> iD8DBQFAFUE35Nfg6kxAQQoRAjQaAKCsdt8QoBH6w2TbtyPSzfpEy1ywMACguflq
> cc6Z79zaEhCmj4C9USs5TBE=
> =oq55
> -----END PGP SIGNATURE-----
> 


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn