Re: [patch] remove null-ifiers

[John Belmonte <john-wanGne27zNesTnJN9+BGXg@public.gmane.org>]

Jes Sorensen wrote:
>"Karol" == Karol Kozimor <sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org> writes:
> Karol> We certainly *don't* want to do that, last time I checked C did
> Karol> not actually guarantee to zero out uninitialized variables --
> Karol> unless it's different in the kernelspace. Are you sure pointers
> Karol> are initialized as NULLs?
> 
> Yes,
> 
> We definately want to do this, this *is* how it works within the
> kernel.

That may be the case, but in the process I think you are destroying 
vital information about which variables the code depends on being 
initialized to zero.  If the Linux kernel ever changed its policy, or if 
the code was used in something other than the Linux kernel (perhaps even 
being translated to some other computer language), you would need that 
information again.

I suggest commenting out the assignment instead of deleting it:

     static int foo /*= 0*/;

-John



-- 
http:// if  ile.org/


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn