Re: ASUS M6800N: processor has only C1

Bruno Ducrot
2004-03-05T11:39:21Z

On Thu, Mar 04, 2004 at 02:53:44PM +0100, Luca Capello wrote:
>
> Hello,
>
> no problem, I forgot to advise you that I can make all the necessary tests to
> bring my new laptop to a completely ACPI working system :-)

Thanks!

>
> > I think also that the bios will only allow C2, not C3 nor C4 if you are on AC.
> You're right, but even on battery I get only C1 & C2 (as from the attached).

Well, there is a stupid bug, I guess.

--- linux-2.6-bk/drivers/acpi/processor.c 2004/03/05 11:14:06 1.3
+++ linux-2.6-bk/drivers/acpi/processor.c 2004/03/05 11:25:58
@@ -666,7 +666,7 @@ acpi_processor_get_power_info_cst (
/* Get all power states */

/* Note that C0 and C1 are filled already by our caller. */
- pr->power.count = 2;
+ pr->power.count = 1;
for (i = 1; i <= count; i++) {
union acpi_object *element;
union acpi_object *obj;
@@ -816,13 +816,10 @@ acpi_processor_get_power_info_cst (
/* All check done. Register this power state. */
cx.valid = 1;
cx.latency_ticks = US_TO_PM_TIMER_TICKS(cx.latency);
- memcpy(&(pr->power.states[pr->power.count]), &cx, sizeof(cx));
(pr->power.count)++;
+ memcpy(&(pr->power.states[pr->power.count]), &cx, sizeof(cx));
}

- /* adjust count. */
- (pr->power.count)--;
-
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Found %d power states\n", pr->power.count));

/* Validate number of power states */
--- linux-2.6-bk/include/acpi/processor.h 2004/03/05 11:26:48 1.2
+++ linux-2.6-bk/include/acpi/processor.h 2004/03/05 11:27:39
@@ -5,7 +5,7 @@

#define ACPI_PROCESSOR_BUSY_METRIC 10

-#define ACPI_PROCESSOR_MAX_POWER ACPI_C_STATE_COUNT
+#define ACPI_PROCESSOR_MAX_POWER 8
#define ACPI_PROCESSOR_MAX_C2_LATENCY 100
#define ACPI_PROCESSOR_MAX_C3_LATENCY 1000

--
Bruno Ducrot

-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.