Moore, Robert wrote:
> The next version of ACPI CA will better manage wake vs. run vs. wake/run
> GPEs and may handle this correctly without the change below.
> 
> Bob

OK. This was fair enough but as I have tried 2.6.6-rc3-mm1 that contains:

ACPI: Subsystem revision 20040326

I still says that the attached patch is indeed badly needed to fix bug 
described in <http://bugme.osdl.org/show_bug.cgi?id=2321>.

Now, as :

	1) this bug is open with several proposed patches for several kernel 
versions for more than a month and a half,
	2) that I never heard anything serious by ACPI developpers about 
possible issue of irq incorrectly restored because (at least on my ASUS 
L3800C) after executing of _WAK irq's are enabled, so stored gpe bits 
(before suspend) will be overwriten and not restored correctly while 
resume (bug analysis by Alexander Malysh),

I would _really_ like to have someone _really_ analyse what happens (I 
can put any trace in my kernel if you ask for it) and propose a better 
fix if this one is not the best way to fix it.

I suspect the problem exist on other systems but as only _few_ do 
correctly wakeup from S3, and even _less_ using dedicated ACPI buttons, 
they are just too many other bugs masking the importance of this one...

But not correctly restoring interrupt status is generally a good way to 
crash a system...

-- 
    __
   /  `                   	Eric Valette
  /--   __  o _.          	6 rue Paul Le Flem
(___, / (_(_(__         	35740 Pace

Tel: +33 (0)2 99 85 26 76	Fax: +33 (0)2 99 85 26 76
E-mail: eric.valette-GANU6spQydw@public.gmane.org