From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Capello Subject: Re: PBLK length again Date: Mon, 21 Jun 2004 22:05:50 +0200 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <40D73F9E.4030805@pca.it> References: <20040620154726.GT20511@parcelfarce.linux.theplanet.co.uk> <1087770015.23371.27.camel@djinn> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1087770015.23371.27.camel-l85cmlzfk8I@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: ML ACPI-devel List-Id: linux-acpi@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, on 06/21/04 00:20, Herman Sheremetyev wrote: > I have an Asus M6N and the Bios DSDT provides a PBLK length of 7 which > causes ACPI to always use the C1 processor state. This laptop > definitely supports C2 and most people have just used custom DSDT's > and changed the value to 6. I don't like using a custom DSDT so I > made a quick kernel patch (attached) to accept 7 as a good value. AFAIK 7 isn't an allowed value from the ACPI-CA specs (but I'm not an expert). BTW, I've an ASUS M6N, too, please refers to this kernel bug: http://bugme.osdl.org/show_bug.cgi?id=1958 I made some tests in the past with the provided Bruno Ducrot's patch (as you can read), but it seems that now the patch is broken. ASAP I'll try your patch, just to confirm that it works on different machines. > My question is, if I make a nicer patch that allows for either strict > interpretation versus a relaxed one, is there a chance that it will > get included? It seems there is enough interest out there to make it > worth the effort. You should wait for someone other's advice, but if PBLK = 7 isn't correct for the ACPI-CA specs, IMHO the solution shouldn't be a workaround like your. Thx, bye, Gismo / Luca -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Debian - http://enigmail.mozdev.org iD8DBQFA1z+eVAp7Xm10JmkRAobWAJ0Us331jNC+JL9PYfMM4x3Ax41JDwCaA0XV 9jqGRccGmDCjTPArZMFBxEQ= =t0/x -----END PGP SIGNATURE----- ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com