Re: [PATCH 1/6]sep initializing rework

[Benoit Boissinot <bboissin@gmail.com>]

On 4/12/05, Li Shaohua <shaohua.li@intel.com> wrote:
> Hi,
> These patches (together with 5 patches followed this one) are updated
> suspend/resume SMP patches. The patches fixed some bugs and do clean up
> as suggested. Now they work for both suspend-to-ram and suspend-to-disk.
> Patches are against 2.6.12-rc2-mm3.
> 
> Thanks,
> Shaohua
> 
> ---
> Make SEP init per-cpu, so it is hotplug safed.
> 
> Signed-off-by: Li Shaohua<shaohua.li@intel.com>
> 
> ---
> +++ linux-2.6.11-root/arch/i386/power/cpu.c     2005-04-12 10:36:00.175169792 +0800
> @@ -33,8 +33,6 @@ unsigned long saved_context_esp, saved_c
>  unsigned long saved_context_esi, saved_context_edi;
>  unsigned long saved_context_eflags;
> 
> -extern void enable_sep_cpu(void *);
> -
>  void __save_processor_state(struct saved_context *ctxt)
>  {
>         kernel_fpu_begin();


> diff -puN include/asm-i386/smp.h~sep_init_cleanup include/asm-i386/smp.h
> --- linux-2.6.11/include/asm-i386/smp.h~sep_init_cleanup        2005-04-12 10:36:00.170170552 +0800
> +++ linux-2.6.11-root/include/asm-i386/smp.h    2005-04-12 10:36:00.176169640 +0800
> @@ -37,6 +37,9 @@ extern int smp_num_siblings;
>  extern cpumask_t cpu_sibling_map[];
>  extern cpumask_t cpu_core_map[];
> 
> +extern int sysenter_setup(void);
> +extern void enable_sep_cpu(void);
> +
>  extern void smp_flush_tlb(void);
>  extern void smp_message_irq(int cpl, void *dev_id, struct pt_regs *regs);
>  extern void smp_invalidate_rcv(void);          /* Process an NMI */
> _

This change adds a warning when CONFIG_SMP is not set:

arch/i386/power/cpu.c: In function '__restore_processor_state':
arch/i386/power/cpu.c:137: warning: implicit declaration of function
'enable_sep_cpu'
Maybe those functions should be defined somewhere else.

regards,

Benoit