acpi_pci_link_allocate() -- latent bug?

acpi_pci_link_allocate() -- latent bug?

[joanna marsden]

I am investigating an interrupt problem on my machine and came across 
the following code, in drivers/acpi/pci_link.c

What happens here if the BIOS sets up these links at the IRQ router at 
boot time, but doesn't restore them after a resume from S3? Is this a 
latent bug? Seems like this routine would eventually be called from 
pci_device_enable, but wouldn't perform the setup we need.

static int acpi_pci_link_allocate(struct acpi_pci_link* link) {
        int irq;
        int i;

        ACPI_FUNCTION_TRACE("acpi_pci_link_allocate");

        if (link->irq.setonboot)
                return_VALUE(0);



-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com

Re: acpi_pci_link_allocate() -- latent bug?

[Len Brown]

Yes, per my response to Nathan's patch, I think
you did find an issue, but should be okay after his patch.

thanks,
-Len

On Sat, 2004-07-31 at 22:40, joanna marsden wrote:
> I am investigating an interrupt problem on my machine and came across 
> the following code, in drivers/acpi/pci_link.c
> 
> What happens here if the BIOS sets up these links at the IRQ router at 
> boot time, but doesn't restore them after a resume from S3? Is this a 
> latent bug? Seems like this routine would eventually be called from 
> pci_device_enable, but wouldn't perform the setup we need.
> 
> static int acpi_pci_link_allocate(struct acpi_pci_link* link) {
>         int irq;
>         int i;
> 
>         ACPI_FUNCTION_TRACE("acpi_pci_link_allocate");
> 
>         if (link->irq.setonboot)
>                 return_VALUE(0);
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by OSTG. Have you noticed the changes on
> Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
> one more big change to announce. We are now OSTG- Open Source Technology
> Group. Come see the changes on the new OSTG site. www.ostg.com
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel



-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com