Re: acpi-20040715: functional regression on ASUS M2N

Matthew Garrett
2004-08-06T15:23:50Z

On Thu, 2004-08-05 at 14:49 -0400, Nathan Bryant wrote:

> The ELCR save/restore patch is causing regressions for some people. What
> if the problem is that we're saving/restoring registers at the wrong time?

On closer investigation, I found that the system was restoring my ioapic
state /after/ it had started the programmable interrupt timer back up.
Changing line 310 of drivers/base/sys.c to list_for_each_entry_reverse
seems to have greatly improved my ability to suspend and resume (which
worked fine before the interrupt controller suspend/resume patches,
except that I didn't get many interrupts...)

There doesn't seem to be any fine-grained way to control the order of
suspend/resume for individual drivers. It seems to be assumed that
everything that devices depend on will be higher than them in the tree,
and so everything will "just work" - I'm not sure this is true. As
another example, I just had my wireless card fail to resume correctly.
It tried to do a hotplug firmware load on resume. Which was difficult,
because it was resumed before the IDE interface was. How can this sort
of thing be avoided?

--
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org

-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com