Hi, The following patch adds brightness setting support to the driver and cleans up the code a bit. It builds on the work of Hiroshi Miura and takes into account the comments of Len Brown and John Belmonte. The patch is against 2.6.8.1-mm1 (though the only thing that might differ between -mm1 and vanilla is the Makefile). I've tested this on my Panasonic CF-R1, and it works beautifully. As far as I am concerned, besides code cleanups (and possibly figuring out the monitor switch thing) this driver is complete. I hope I haven't stepped on any toes here. David Bronaugh --------- Supporting bits: # /etc/acpi/events/hotkey # This script handles hotkey events on Panasonic notebooks event=HKEY.* action=/etc/acpi/hotkey.sh %e ---------------------- #!/bin/bash # Handles hotkey events for Panasonic notebooks KEY=$4 BRIGHTNESS_CONTROL=/proc/acpi/pcc/brightness VOLADJUST=5 GETVOLCMD="amixer cget numid=2" GETMUTECMD="amixer cget numid=1" SETVOLCMD="amixer cset numid=2" SETMUTECMD="amixer cset numid=1" case "$KEY" in 00000001) logger "acpid: received a down brightness event" BRIGHT=`cat /proc/acpi/pcc/brightness` let BRIGHT=BRIGHT-1 echo $BRIGHT > $BRIGHTNESS_CONTROL ;; 00000002) logger "acpid: received an up brightness event" BRIGHT=`cat /proc/acpi/pcc/brightness` let BRIGHT=BRIGHT+1 echo $BRIGHT > $BRIGHTNESS_CONTROL ;; 00000003) logger "acpid: received a monitor switch event (unhandled)" ;; 00000004) logger "acpid: received a sound mute event" ;; 00000005) logger "acpid: received a volume down event" ;; 00000006) logger "acpid: received a volume up event" ;; 00000007) logger "acpid: received a suspend-to-RAM event (unhandled)" ;; 00000009) logger "acpid: received a disk spindown event" ;; 0000000a) logger "acpid: received a suspend-to-disk event" ;; *) logger "acpid: received unhandled event $KEY" ;; esac