Early init patch breaks Dell laptops

Early init patch breaks Dell laptops

[Daniel Drake]

Hi Len,

I'm one of the maintainers of Gentoo's kernel packages. I recently added your 
ACPI early-init patch into our 2.6.8 patchset in order to solve the problems 
you addressed

http://bugs.gentoo.org/60565
http://bugzilla.kernel.org/show_bug.cgi?id=2941

After adding the "2.6.7 early init" patch, other users have run into 
ACPI-related problems (freezing on ACPI events). More specifically, Dell 
Inspiron laptops don't seem to like you :)

According to these users, the issue is also present in (unmodified) 2.6.9-rc3, 
and reverting out the early-init patch seems to solve the problem.

http://bugs.gentoo.org/66723
http://bugs.gentoo.org/66804
http://bugs.gentoo.org/66613

A bug has been filed at the kernel bugzilla:

http://bugzilla.kernel.org/show_bug.cgi?id=3532

I hope this is useful- please ask if you need any more info.

Thanks,
Daniel


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

RE: Early init patch breaks Dell laptops

[Yu, Luming]

 
Would you please try boot option nolapic?

Thanks,
Luming

>-----Original Message-----
>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org 
>[mailto:acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of 
>Daniel Drake
>Sent: Saturday, October 09, 2004 10:08 PM
>To: Brown, Len
>Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: [ACPI] Early init patch breaks Dell laptops
>
>Hi Len,
>
>I'm one of the maintainers of Gentoo's kernel packages. I 
>recently added your 
>ACPI early-init patch into our 2.6.8 patchset in order to 
>solve the problems 
>you addressed
>
>http://bugs.gentoo.org/60565
>http://bugzilla.kernel.org/show_bug.cgi?id=2941
>
>After adding the "2.6.7 early init" patch, other users have run into 
>ACPI-related problems (freezing on ACPI events). More 
>specifically, Dell 
>Inspiron laptops don't seem to like you :)
>
>According to these users, the issue is also present in 
>(unmodified) 2.6.9-rc3, 
>and reverting out the early-init patch seems to solve the problem.
>
>http://bugs.gentoo.org/66723
>http://bugs.gentoo.org/66804
>http://bugs.gentoo.org/66613
>
>A bug has been filed at the kernel bugzilla:
>
>http://bugzilla.kernel.org/show_bug.cgi?id=3532
>
>I hope this is useful- please ask if you need any more info.
>
>Thanks,
>Daniel
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: IT Product Guide on 
>ITManagersJournal
>Use IT products in your business? Tell us what you think of 
>them. Give us
>Your Opinions, Get Free ThinkGeek Gift Certificates! Click to 
>find out more
>http://productguide.itmanagersjournal.com/guidepromo.tmpl
>_______________________________________________
>Acpi-devel mailing list
>Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>https://lists.sourceforge.net/lists/listinfo/acpi-devel
>


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: Early init patch breaks Dell laptops

[Daniel Drake]

Hi,

Yu, Luming wrote:
>  
> Would you please try boot option nolapic?

Thanks for the suggestion - that does solve the problem. Is this an APIC bug?

Daniel


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

RE: Early init patch breaks Dell laptops

[Brown, Len]

I think the bug is that Linux
enables the LAPIC instead of believeing
the BIOS that it should be off:

+Local APIC disabled by BIOS -- reenabling.
+Found and enabled local APIC!

-Len 

>-----Original Message-----
>From: Daniel Drake [mailto:dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org] 
>Sent: Saturday, October 09, 2004 10:08 AM
>To: Brown, Len
>Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: Early init patch breaks Dell laptops
>
>Hi Len,
>
>I'm one of the maintainers of Gentoo's kernel packages. I 
>recently added your 
>ACPI early-init patch into our 2.6.8 patchset in order to 
>solve the problems 
>you addressed
>
>http://bugs.gentoo.org/60565
>http://bugzilla.kernel.org/show_bug.cgi?id=2941
>
>After adding the "2.6.7 early init" patch, other users have run into 
>ACPI-related problems (freezing on ACPI events). More 
>specifically, Dell 
>Inspiron laptops don't seem to like you :)
>
>According to these users, the issue is also present in 
>(unmodified) 2.6.9-rc3, 
>and reverting out the early-init patch seems to solve the problem.
>
>http://bugs.gentoo.org/66723
>http://bugs.gentoo.org/66804
>http://bugs.gentoo.org/66613
>
>A bug has been filed at the kernel bugzilla:
>
>http://bugzilla.kernel.org/show_bug.cgi?id=3532
>
>I hope this is useful- please ask if you need any more info.
>
>Thanks,
>Daniel
>


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: Early init patch breaks Dell laptops

[Len Brown]

[-- Attachment #1: Type: text/plain, Size: 76 bytes --]

Let me know if this doesn't address all of the regressions.

thanks,
-Len



[-- Attachment #2: lapic.patch --]
[-- Type: text/plain, Size: 836 bytes --]

===== arch/i386/kernel/apic.c 1.60 vs 1.61 =====
--- 1.60/arch/i386/kernel/apic.c	2004-10-06 21:10:37 -04:00
+++ 1.61/arch/i386/kernel/apic.c	2004-10-10 04:12:38 -04:00
@@ -690,22 +690,8 @@
 		goto no_apic;
 	}
 
-	if (!cpu_has_apic) {
-		/*
-		 * Some BIOSes disable the local APIC in the
-		 * APIC_BASE MSR. This can only be done in
-		 * software for Intel P6 and AMD K7 (Model > 1).
-		 */
-		rdmsr(MSR_IA32_APICBASE, l, h);
-		if (!(l & MSR_IA32_APICBASE_ENABLE)) {
-			apic_printk(APIC_VERBOSE, "Local APIC disabled "
-					"by BIOS -- reenabling.\n");
-			l &= ~MSR_IA32_APICBASE_BASE;
-			l |= MSR_IA32_APICBASE_ENABLE | APIC_DEFAULT_PHYS_BASE;
-			wrmsr(MSR_IA32_APICBASE, l, h);
-			enabled_via_apicbase = 1;
-		}
-	}
+	if (!cpu_has_apic)
+		goto no_apic;
 	/*
 	 * The APIC feature bit should now be enabled
 	 * in `cpuid'

RE: Early init patch breaks Dell laptops

[Li, Shaohua]

How about enable lapic if ACPI isn't enabled?

-Shaohua

>-----Original Message-----
>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
>admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Len Brown
>Sent: Sunday, October 10, 2004 4:45 PM
>To: Daniel Drake
>Cc: Yu, Luming; ACPI Developers
>Subject: Re: [ACPI] Early init patch breaks Dell laptops
>
>Let me know if this doesn't address all of the regressions.
>
>thanks,
>-Len
>



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

RE: Early init patch breaks Dell laptops

[Len Brown]

Good idea, but it turns out that LAPIC 
causes the D600 poweroff to fail with or without ACPI.

Also, I recall another Dell system's APM suspend
didn't work with the LAPIC enabled.

So I think the simpler patch is better.

thanks,
-Len

On Sun, 2004-10-10 at 05:00, Li, Shaohua wrote:
> How about enable lapic if ACPI isn't enabled?
> 
> -Shaohua
> 
> >-----Original Message-----
> >From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> >admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Len Brown
> >Sent: Sunday, October 10, 2004 4:45 PM
> >To: Daniel Drake
> >Cc: Yu, Luming; ACPI Developers
> >Subject: Re: [ACPI] Early init patch breaks Dell laptops
> >
> >Let me know if this doesn't address all of the regressions.
> >
> >thanks,
> >-Len
> >
> 



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: Early init patch breaks Dell laptops

[Daniel Drake]

Len Brown wrote:
> Let me know if this doesn't address all of the regressions.

At least for 1 user, that appears to have solved it. Thanks!

Daniel

> 
> ===== arch/i386/kernel/apic.c 1.60 vs 1.61 =====
> --- 1.60/arch/i386/kernel/apic.c	2004-10-06 21:10:37 -04:00
> +++ 1.61/arch/i386/kernel/apic.c	2004-10-10 04:12:38 -04:00
> @@ -690,22 +690,8 @@
>  		goto no_apic;
>  	}
>  
> -	if (!cpu_has_apic) {
> -		/*
> -		 * Some BIOSes disable the local APIC in the
> -		 * APIC_BASE MSR. This can only be done in
> -		 * software for Intel P6 and AMD K7 (Model > 1).
> -		 */
> -		rdmsr(MSR_IA32_APICBASE, l, h);
> -		if (!(l & MSR_IA32_APICBASE_ENABLE)) {
> -			apic_printk(APIC_VERBOSE, "Local APIC disabled "
> -					"by BIOS -- reenabling.\n");
> -			l &= ~MSR_IA32_APICBASE_BASE;
> -			l |= MSR_IA32_APICBASE_ENABLE | APIC_DEFAULT_PHYS_BASE;
> -			wrmsr(MSR_IA32_APICBASE, l, h);
> -			enabled_via_apicbase = 1;
> -		}
> -	}
> +	if (!cpu_has_apic)
> +		goto no_apic;
>  	/*
>  	 * The APIC feature bit should now be enabled
>  	 * in `cpuid'



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl