Re: Early init patch breaks Dell laptops

[Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>]

Len Brown wrote:
> Let me know if this doesn't address all of the regressions.

At least for 1 user, that appears to have solved it. Thanks!

Daniel

> 
> ===== arch/i386/kernel/apic.c 1.60 vs 1.61 =====
> --- 1.60/arch/i386/kernel/apic.c	2004-10-06 21:10:37 -04:00
> +++ 1.61/arch/i386/kernel/apic.c	2004-10-10 04:12:38 -04:00
> @@ -690,22 +690,8 @@
>  		goto no_apic;
>  	}
>  
> -	if (!cpu_has_apic) {
> -		/*
> -		 * Some BIOSes disable the local APIC in the
> -		 * APIC_BASE MSR. This can only be done in
> -		 * software for Intel P6 and AMD K7 (Model > 1).
> -		 */
> -		rdmsr(MSR_IA32_APICBASE, l, h);
> -		if (!(l & MSR_IA32_APICBASE_ENABLE)) {
> -			apic_printk(APIC_VERBOSE, "Local APIC disabled "
> -					"by BIOS -- reenabling.\n");
> -			l &= ~MSR_IA32_APICBASE_BASE;
> -			l |= MSR_IA32_APICBASE_ENABLE | APIC_DEFAULT_PHYS_BASE;
> -			wrmsr(MSR_IA32_APICBASE, l, h);
> -			enabled_via_apicbase = 1;
> -		}
> -	}
> +	if (!cpu_has_apic)
> +		goto no_apic;
>  	/*
>  	 * The APIC feature bit should now be enabled
>  	 * in `cpuid'



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl