[PATCH] ACPI based Memory Hotplug Driver Patch Update

[PATCH] ACPI based Memory Hotplug Driver Patch Update

[S, Naveen B]

Hi,

Attaching the updated ACPI Memory Driver Patch along with this mail.
This implements review feedback and is ported to latest kernel
(2.6.9-rc4-mm1). And this is tested on the real hardware with patchset
available in http://sprucegoose.sr71.net/patches

Let me know for any clarifications.

Tokunaga, 
This does not include your patch yet. Would like to test and consider it
in the subsequent patches once the base driver gets into the kernel.

Len, 
Can you consider this for inclusion? Please let me know.

Thanks & Regards

Signed-off-by: Naveen B S <naveen.b.s-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Matt Tolentino <matthew.e.tolentino-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

 drivers/acpi/Kconfig           |    7 
 drivers/acpi/Makefile          |    1 
 drivers/acpi/acpi_ksyms.c      |    1 
 drivers/acpi/acpi_memhotplug.c |  542
+++++++++++++++++++++++++++++++++++++++++
 drivers/acpi/scan.c            |    2 
 include/acpi/acpi_bus.h        |    2 
 6 files changed, 554 insertions(+), 1 deletion(-)

diff -Nura linux-2.6.9-rc4-mm1-orig/drivers/acpi/acpi_ksyms.c
linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/acpi_ksyms.c
--- linux-2.6.9-rc4-mm1-orig/drivers/acpi/acpi_ksyms.c	2004-10-12
12:02:48.000000000 -0400
+++ linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/acpi_ksyms.c	2004-10-12
13:58:19.000000000 -0400
@@ -138,6 +138,7 @@
 EXPORT_SYMBOL(acpi_bus_receive_event);
 EXPORT_SYMBOL(acpi_bus_register_driver);
 EXPORT_SYMBOL(acpi_bus_unregister_driver);
+EXPORT_SYMBOL(acpi_bus_add);
 
 #endif /*CONFIG_ACPI_BUS*/
 
diff -Nura linux-2.6.9-rc4-mm1-orig/drivers/acpi/acpi_memhotplug.c
linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/acpi_memhotplug.c
--- linux-2.6.9-rc4-mm1-orig/drivers/acpi/acpi_memhotplug.c
1969-12-31 19:00:00.000000000 -0500
+++ linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/acpi_memhotplug.c
2004-10-12 14:08:56.000000000 -0400
@@ -0,0 +1,542 @@
+/*
+ * Copyright (C) 2004 Intel Corporation <naveen.b.s-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+ *
+ * All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
(at
+ * your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
+ * NON INFRINGEMENT.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ *
+ * ACPI based HotPlug driver that supports Memory Hotplug 
+ * This driver fields notifications from firmare for memory add
+ * and remove operations and alerts the VM of the affected memory
+ * ranges.  
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/types.h>
+#include <linux/memory_hotplug.h>
+#include <acpi/acpi_drivers.h>
+
+
+#define ACPI_MEMORY_DEVICE_COMPONENT		0x08000000UL
+#define ACPI_MEMORY_DEVICE_CLASS		"memory"
+#define ACPI_MEMORY_DEVICE_HID			"PNP0C80"
+#define ACPI_MEMORY_DEVICE_DRIVER_NAME		"Hotplug Mem Driver"
+#define ACPI_MEMORY_DEVICE_NAME			"Hotplug Mem
Device"
+
+#define _COMPONENT		ACPI_MEMORY_DEVICE_COMPONENT
+
+ACPI_MODULE_NAME		("acpi_memory")
+MODULE_AUTHOR("Naveen B S <naveen.b.s-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>");
+MODULE_DESCRIPTION(ACPI_MEMORY_DEVICE_DRIVER_NAME);
+MODULE_LICENSE("GPL");
+
+/* ACPI _STA method values */
+#define ACPI_MEMORY_STA_PRESENT		(0x00000001UL)
+#define ACPI_MEMORY_STA_ENABLED		(0x00000002UL)
+#define ACPI_MEMORY_STA_FUNCTIONAL	(0x00000008UL)
+
+/* Memory Device States */
+#define MEMORY_INVALID_STATE	0
+#define MEMORY_POWER_ON_STATE	1
+#define MEMORY_POWER_OFF_STATE	2
+
+static int acpi_memory_device_add (struct acpi_device *device);
+static int acpi_memory_device_remove (struct acpi_device *device, int
type);
+
+static struct acpi_driver acpi_memory_device_driver = {
+	.name =		ACPI_MEMORY_DEVICE_DRIVER_NAME,
+	.class =	ACPI_MEMORY_DEVICE_CLASS,
+	.ids =		ACPI_MEMORY_DEVICE_HID,
+	.ops =		{
+				.add =		acpi_memory_device_add,
+				.remove =
acpi_memory_device_remove,
+			},
+};
+
+struct acpi_memory_device {
+	acpi_handle handle;	
+	unsigned int state;		/* State of the memory device */
+	unsigned short cache_attribute;	/* memory cache attribute */
+	unsigned short read_write_attribute;/* memory read/write
attribute */
+	u64 start_addr;	/* Memory Range start physical addr */
+	u64 end_addr;	/* Memory Range end physical addr */
+};
+
+
+static int 
+acpi_memory_get_device_resources(struct acpi_memory_device *mem_device)

+{
+	acpi_status status;
+	struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};	
+	struct acpi_resource *resource = NULL;
+	struct acpi_resource_address64 address64;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_get_device_resources");
+
+	/* Get the range from the _CRS */
+	status = acpi_get_current_resources(mem_device->handle,
&buffer);
+	if (ACPI_FAILURE(status))
+		return_VALUE(-EINVAL);
+
+	resource = (struct acpi_resource *) buffer.pointer;
+	status = acpi_resource_to_address64(resource, &address64);

+	if (ACPI_SUCCESS(status)) {
+		if (address64.resource_type == ACPI_MEMORY_RANGE) {
+			/* Populate the structure */
+			mem_device->cache_attribute = 
+
address64.attribute.memory.cache_attribute;
+			mem_device->read_write_attribute = 
+			address64.attribute.memory.read_write_attribute;
+			mem_device->start_addr =
address64.min_address_range;
+			mem_device->end_addr =
address64.max_address_range;
+		}
+	}
+		
+	acpi_os_free(buffer.pointer);
+	return_VALUE(0);
+}
+
+static int 
+acpi_memory_get_device(acpi_handle handle,
+	struct acpi_memory_device **mem_device) 
+{
+	acpi_status status;
+	acpi_handle phandle;
+	struct acpi_device *device = NULL;
+	struct acpi_device *pdevice = NULL;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_get_device");
+
+	if (!acpi_bus_get_device(handle, &device) && device) 
+		goto end;
+	
+	status = acpi_get_parent(handle, &phandle);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+			"Error in acpi_get_parent\n"));
+		return_VALUE(-EINVAL);
+	}
+
+	/* Get the parent device */
+	status = acpi_bus_get_device(phandle, &pdevice);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+			"Error in acpi_bus_get_device\n"));
+		return_VALUE(-EINVAL);
+	}
+	
+	/* 
+	 * Now add the notified device.  This creates the acpi_device 
+	 * and invokes .add function 
+	 */
+	status = acpi_bus_add(&device, pdevice, handle,
ACPI_BUS_TYPE_DEVICE);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+			"Error in acpi_bus_add\n"));
+		return_VALUE(-EINVAL);
+	}
+
+end:
+	*mem_device = acpi_driver_data(device);
+	if (!(*mem_device)) {
+		printk(KERN_ERR "\n driver data not found" );
+		return_VALUE(-ENODEV);
+	}
+
+	return_VALUE(0);
+}
+
+static int 
+acpi_memory_check_device(struct acpi_memory_device *mem_device)
+{
+	unsigned long current_status;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_check_device");
+
+	/* Get device present/absent information from the _STA */
+	if (ACPI_FAILURE(acpi_evaluate_integer(mem_device->handle,
"_STA", 
+		NULL, &current_status)))
+		return_VALUE(-ENODEV);
+	/* 
+	 * Check for device status. Device should be 
+	 * present/enabled/functioning.
+	 */
+	if (!((current_status & ACPI_MEMORY_STA_PRESENT)
+		&& (current_status & ACPI_MEMORY_STA_ENABLED)
+		&& (current_status & ACPI_MEMORY_STA_FUNCTIONAL))) 
+		return_VALUE(-ENODEV);
+
+	return_VALUE(0);
+}
+
+static int 
+acpi_memory_enable_device(struct acpi_memory_device *mem_device)
+{
+	int result;
+	
+	ACPI_FUNCTION_TRACE("acpi_memory_enable_device");
+
+	/* Get the range from the _CRS */
+	result = acpi_memory_get_device_resources(mem_device); 
+	if (result) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, 
+			"\nget_device_resources failed\n"));
+		mem_device->state = MEMORY_INVALID_STATE;		
+		return result;
+	}
+
+	/* 
+	 * Tell the VM there is more memory here...
+	 * Note: Assume that this function returns zero on success 
+	 */
+	result = add_memory(mem_device->start_addr, 
+			(mem_device->end_addr - mem_device->start_addr)
+ 1,
+			mem_device->read_write_attribute);
+	if (result) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, 
+			"\nadd_memory failed\n"));
+		mem_device->state = MEMORY_INVALID_STATE;		
+		return result;
+	}
+
+	return result;
+}
+
+static int 
+acpi_memory_powerdown_device(struct acpi_memory_device *mem_device)
+{
+	acpi_status status;
+	struct acpi_object_list	arg_list;
+	union acpi_object arg;
+	unsigned long current_status;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_powerdown_device");
+
+	/* Issue the _EJ0 command */
+	arg_list.count = 1;
+	arg_list.pointer = &arg;
+	arg.type = ACPI_TYPE_INTEGER;
+	arg.integer.value = 1;
+	status = acpi_evaluate_object(mem_device->handle, 
+			"_EJ0", &arg_list, NULL);
+	/* Return on _EJ0 failure */
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,"_EJ0 failed.\n"));
+		return_VALUE(-ENODEV);		
+	}
+
+	/* Evalute _STA to check if the device is disabled */
+	status = acpi_evaluate_integer(mem_device->handle, "_STA", 
+		NULL, &current_status);
+	if (ACPI_FAILURE(status))
+		return_VALUE(-ENODEV);
+
+	/* Check for device status.  Device should be disabled */
+	if (current_status & ACPI_MEMORY_STA_ENABLED) 
+		return_VALUE(-EINVAL);
+
+	return_VALUE(0);
+}
+
+static int 
+acpi_memory_disable_device(struct acpi_memory_device *mem_device) 
+{
+	int result;
+	u64 start = mem_device->start_addr;
+	u64 len = mem_device->end_addr - start + 1;
+	unsigned long attr = mem_device->read_write_attribute;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_disable_device");
+
+	/* 
+	 * Ask the VM to offline this memory range.
+	 * Note: Assume that this function returns zero on success 
+	 */
+	result = remove_memory(start, len, attr);
+	if (result) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Hot-Remove
failed.\n"));
+		return_VALUE(result);	
+	}
+
+	/* Power-off and eject the device */
+	result = acpi_memory_powerdown_device(mem_device);	
+	if (result) { 
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+					"Device Power Down failed.\n"));
+		/* Set the status of the device to invalid */
+		mem_device->state = MEMORY_INVALID_STATE;
+		return result;
+	}
+	
+	mem_device->state = MEMORY_POWER_OFF_STATE;
+	return result;	
+}
+
+static void
+acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
+{
+	struct acpi_memory_device *mem_device;
+	struct acpi_device *device;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_device_notify");
+
+	switch (event) {
+	case ACPI_NOTIFY_BUS_CHECK:
+		ACPI_DEBUG_PRINT((ACPI_DB_INFO, 
+			"\nReceived BUS CHECK notification for
device\n"));
+		/* Fall Through */
+	case ACPI_NOTIFY_DEVICE_CHECK:
+		if (event == ACPI_NOTIFY_DEVICE_CHECK)
+			ACPI_DEBUG_PRINT((ACPI_DB_INFO, 
+			"\nReceived DEVICE CHECK notification for
device\n"));
+		if (acpi_memory_get_device(handle, &mem_device)) {
+			ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+				"Error in finding driver data\n"));
+			return_VOID;
+		}
+		
+		if (!acpi_memory_check_device(mem_device)) {
+			if (acpi_memory_enable_device(mem_device))
+				ACPI_DEBUG_PRINT((ACPI_DB_ERROR, 
+				"Error in
acpi_memory_enable_device\n"));
+		}
+		break;
+	case ACPI_NOTIFY_EJECT_REQUEST:
+		ACPI_DEBUG_PRINT((ACPI_DB_INFO, 
+			"\nReceived EJECT REQUEST notification for
device\n"));
+		
+		if (acpi_bus_get_device(handle, &device)) {
+			ACPI_DEBUG_PRINT((ACPI_DB_ERROR, 
+					"Device doesn't exist\n"));
+			break;
+		}
+		mem_device = acpi_driver_data(device);
+		if (!mem_device) {
+			ACPI_DEBUG_PRINT((ACPI_DB_ERROR, 
+					"Driver Data is NULL\n"));
+			break;
+		}
+	
+		/*
+		 * Currently disabling memory device from kernel mode
+		 * TBD: Can also be disabled from user mode scripts
+		 * TBD: Can also be disabled by Callback registration 
+		 * 	with generic sysfs driver
+		 */	
+		if (acpi_memory_disable_device(mem_device))
+			ACPI_DEBUG_PRINT((ACPI_DB_ERROR, 
+				"Error in
acpi_memory_disable_device\n"));
+		/*
+		 * TBD: Invoke acpi_bus_remove to cleanup data
structures
+		 */
+		break;
+	default:
+		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+			"Unsupported event [0x%x]\n", event));
+		break;
+	}
+
+	return_VOID;
+}
+
+static int
+acpi_memory_device_add(struct acpi_device *device)
+{
+	int result;
+	struct acpi_memory_device *mem_device = NULL;
+	
+	ACPI_FUNCTION_TRACE("acpi_memory_device_add");
+
+	if (!device)
+		return_VALUE(-EINVAL);
+
+	mem_device = kmalloc(sizeof(struct acpi_memory_device),
GFP_KERNEL);
+	if (!mem_device)
+		return_VALUE(-ENOMEM);
+	memset(mem_device, 0, sizeof(struct acpi_memory_device));
+
+	mem_device->handle = device->handle;
+	sprintf(acpi_device_name(device), "%s",
ACPI_MEMORY_DEVICE_NAME);
+	sprintf(acpi_device_class(device), "%s",
ACPI_MEMORY_DEVICE_CLASS);
+	acpi_driver_data(device) = mem_device;
+
+	/* Get the range from the _CRS */
+	result = acpi_memory_get_device_resources(mem_device);
+	if (result) {
+		kfree(mem_device);
+		return_VALUE(result);
+	}
+		
+	/* Set the device state */
+	mem_device->state = MEMORY_POWER_ON_STATE;
+
+	printk(KERN_INFO "%s \n", acpi_device_name(device));
+
+	return_VALUE(result);
+}
+
+static int 
+acpi_memory_device_remove (struct acpi_device *device, int type)
+{
+	struct acpi_memory_device *mem_device = NULL;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_device_remove");
+
+	if (!device || !acpi_driver_data(device))
+		return_VALUE(-EINVAL);
+	
+	mem_device = (struct acpi_memory_device *)
acpi_driver_data(device);
+	kfree(mem_device);
+
+	return_VALUE(0);
+}
+
+/* 
+ * Helper function to check for memory device 
+ */
+static acpi_status 
+is_memory_device(acpi_handle handle) 
+{
+	char *hardware_id;
+	acpi_status status;
+	struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
+	struct acpi_device_info *info;
+	
+	ACPI_FUNCTION_TRACE("is_memory_device");
+
+	status = acpi_get_object_info(handle, &buffer);
+	if (ACPI_FAILURE(status)) 
+		return_ACPI_STATUS(AE_ERROR);
+	
+	info = buffer.pointer;
+	if (!(info->valid & ACPI_VALID_HID)) {
+		acpi_os_free(buffer.pointer);
+		return_ACPI_STATUS(AE_ERROR);
+	}
+	
+	hardware_id = info->hardware_id.value;
+	if ((hardware_id == NULL) || 
+		(strcmp(hardware_id, ACPI_MEMORY_DEVICE_HID))) 
+		status = AE_ERROR;
+	
+	acpi_os_free(buffer.pointer);
+	return_ACPI_STATUS(status);	
+}
+
+static acpi_status
+acpi_memory_register_notify_handler (acpi_handle handle, 
+	u32 level, void *ctxt, void **retv)
+{
+	acpi_status status;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_register_notify_handler");
+	
+	status = is_memory_device(handle);
+	if (ACPI_FAILURE(status)) 
+		return_ACPI_STATUS(AE_OK);	/* continue */
+	
+	status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,

+			acpi_memory_device_notify, NULL);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+			"Error installing notify handler\n"));
+		return_ACPI_STATUS(AE_OK);	/* continue */
+	}
+		
+	return_ACPI_STATUS(status);	
+}
+
+static acpi_status
+acpi_memory_deregister_notify_handler (acpi_handle handle, 
+			       u32 level, void *ctxt, void **retv)
+{
+	acpi_status status;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_deregister_notify_handler");
+	
+	status = is_memory_device(handle);
+	if (ACPI_FAILURE(status)) 
+		return_ACPI_STATUS(AE_OK);	/* continue */
+	
+	status = acpi_remove_notify_handler(handle,
+			ACPI_SYSTEM_NOTIFY, acpi_memory_device_notify);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+				"Error removing notify handler\n"));
+		return_ACPI_STATUS(AE_OK);	/* continue */
+	}
+	
+	return_ACPI_STATUS(status);	
+}
+
+static int __init
+acpi_memory_device_init (void)
+{
+	int result;
+	acpi_status status;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_device_init");
+
+	result = acpi_bus_register_driver(&acpi_memory_device_driver);
+
+	if (result < 0) 
+		return_VALUE(-ENODEV);
+	
+	status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,

+				ACPI_UINT32_MAX,
+				acpi_memory_register_notify_handler, 
+				NULL, NULL);
+
+	if (ACPI_FAILURE (status)) {
+		ACPI_DEBUG_PRINT ((ACPI_DB_ERROR, "walk_namespace
failed\n"));
+		acpi_bus_unregister_driver(&acpi_memory_device_driver);
+		return_VALUE(-ENODEV);
+        }
+
+	return_VALUE(0);
+}
+
+static void __exit
+acpi_memory_device_exit (void)
+{
+	acpi_status status;
+
+	ACPI_FUNCTION_TRACE("acpi_memory_device_exit");
+	
+	/* 
+	 * Adding this to un-install notification handlers for all the
device
+	 * handles. 
+	 */
+	status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,

+			ACPI_UINT32_MAX,
+			acpi_memory_deregister_notify_handler, 
+			NULL, NULL);
+
+	if (ACPI_FAILURE (status)) 
+		ACPI_DEBUG_PRINT ((ACPI_DB_ERROR, "walk_namespace
failed\n"));
+
+	acpi_bus_unregister_driver(&acpi_memory_device_driver);
+
+	return_VOID;
+}
+
+module_init(acpi_memory_device_init);
+module_exit(acpi_memory_device_exit);
+
+
diff -Nura linux-2.6.9-rc4-mm1-orig/drivers/acpi/Kconfig
linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/Kconfig
--- linux-2.6.9-rc4-mm1-orig/drivers/acpi/Kconfig	2004-10-12
12:02:48.000000000 -0400
+++ linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/Kconfig	2004-10-12
13:58:19.000000000 -0400
@@ -307,5 +307,12 @@
 	  kernel logs, and/or you are using this on a notebook which
 	  does not yet have an HPET, you should say "Y" here.
 
+config ACPI_HOTPLUG_MEMORY
+	tristate "Memory Hotplug"
+	depends on ACPI
+	depends on MEMORY_HOTPLUG
+	default m
+	help
+	  This driver adds supports for ACPI Memory Hotplug.
 endmenu
 
diff -Nura linux-2.6.9-rc4-mm1-orig/drivers/acpi/Makefile
linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/Makefile
--- linux-2.6.9-rc4-mm1-orig/drivers/acpi/Makefile	2004-10-12
12:02:48.000000000 -0400
+++ linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/Makefile	2004-10-12
14:09:28.000000000 -0400
@@ -49,3 +49,4 @@
 obj-$(CONFIG_ACPI_TOSHIBA)	+= toshiba_acpi.o
 obj-$(CONFIG_ACPI_THINKPAD)	+= thinkpad_acpi.o
 obj-$(CONFIG_ACPI_BUS)		+= scan.o motherboard.o
+obj-$(CONFIG_ACPI_HOTPLUG_MEMORY)	+= acpi_memhotplug.o
diff -Nura linux-2.6.9-rc4-mm1-orig/drivers/acpi/scan.c
linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/scan.c
--- linux-2.6.9-rc4-mm1-orig/drivers/acpi/scan.c	2004-10-12
12:01:46.000000000 -0400
+++ linux-2.6.9-rc4-mm1-hpmem/drivers/acpi/scan.c	2004-10-12
13:58:19.000000000 -0400
@@ -760,7 +760,7 @@
 #endif /*CONFIG_ACPI_DEBUG_OUTPUT*/
 }
 
-static int 
+int 
 acpi_bus_add (
 	struct acpi_device	**child,
 	struct acpi_device	*parent,
diff -Nura linux-2.6.9-rc4-mm1-orig/include/acpi/acpi_bus.h
linux-2.6.9-rc4-mm1-hpmem/include/acpi/acpi_bus.h
--- linux-2.6.9-rc4-mm1-orig/include/acpi/acpi_bus.h	2004-10-12
12:01:59.000000000 -0400
+++ linux-2.6.9-rc4-mm1-hpmem/include/acpi/acpi_bus.h	2004-10-12
13:58:19.000000000 -0400
@@ -321,6 +321,8 @@
 int acpi_bus_receive_event (struct acpi_bus_event *event);
 int acpi_bus_register_driver (struct acpi_driver *driver);
 int acpi_bus_unregister_driver (struct acpi_driver *driver);
+int acpi_bus_add (struct acpi_device **child, struct acpi_device
*parent,
+						acpi_handle handle, int
type);
 
 int acpi_create_dir(struct acpi_device *);
 void acpi_remove_dir(struct acpi_device *);





-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Dave Hansen]

On Tue, 2004-10-12 at 16:29, S, Naveen B wrote: 
> +#define ACPI_MEMORY_DEVICE_HID			"PNP0C80"
> +#define ACPI_MEMORY_DEVICE_DRIVER_NAME		"Hotplug Mem Driver"
> +#define ACPI_MEMORY_DEVICE_NAME			"Hotplug Mem
> Device"
> +
> +#define _COMPONENT		ACPI_MEMORY_DEVICE_COMPONENT

Looks whitespace mangled to me.  Can you try an attachment?

-- Dave



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Dave Hansen]

On Tue, 2004-10-12 at 16:29, S, Naveen B wrote:
> Attaching the updated ACPI Memory Driver Patch along with this mail.
> This implements review feedback and is ported to latest kernel
> (2.6.9-rc4-mm1). And this is tested on the real hardware with patchset
> available in http://sprucegoose.sr71.net/patches
> 
> Let me know for any clarifications.

Other than the whitespace problems, this looks pretty sane to me.  Would
you like me to add it to the patch set?  

-- Dave



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Dave Hansen]

One more thing, can you give me a short summary of what this patch does,
and maybe what kind of hardware it's useful on for the changelog?

-- Dave



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Hiroyuki KAMEZAWA]

as Bjohn said.
> I'm not sure you should assume the range will be the only item in _CRS
> (i.e., you may need to iterate over all items using acpi_walk_resources()).

I think you should use acpi_walk_resources(), like below.

By the way,a _CRS cannot contain plural address information ?

Kame <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

S, Naveen B wrote:
+static int
+acpi_memory_enable_device(struct acpi_memory_device *mem_device)
+{
+	int result;
+	
+	ACPI_FUNCTION_TRACE("acpi_memory_enable_device");
+
+	/* Get the range from the _CRS */
+	result = acpi_memory_get_device_resources(mem_device);

result = acpi_walk_resources(mem_device->handle, METHOD_NAME_CRS,
                              acpi_memory_get_device_resources, mem_device);

+	if (result) {
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+			"\nget_device_resources failed\n"));
+		mem_device->state = MEMORY_INVALID_STATE;		
+		return result;
+	}

-- 
--the clue is these footmarks leading to the door.--
KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Keiichiro Tokunaga]

Hi Naveen,

On Wed, 13 Oct 2004 04:59:46 +0530 S, Naveen B wrote:
> Tokunaga, 
> This does not include your patch yet. Would like to test and consider it
> in the subsequent patches once the base driver gets into the kernel.

Okay.  Thanks for letting me know about that.

Thanks,
Keiichiro Tokunaga


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

RE: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[S, Naveen B]

> as Bjohn said.
> > I'm not sure you should assume the range will be the only item in
_CRS
> > (i.e., you may need to iterate over all items using
> acpi_walk_resources()).
> 
> I think you should use acpi_walk_resources(), like below.
> 
> By the way,a _CRS cannot contain plural address information ?
> 
> Kame kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org

Thanks Kame,
As I was mentioning earlier, my understanding from the spec that the
memory device has only range in _CRS. So I believe acpi_walk_resources
is redundant in this case. Anyway this could be changed if it is a real
concern.
Please let me know.

--Naveen


> 
> S, Naveen B wrote:
> +static int
> +acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> +{
> +	int result;
> +
> +	ACPI_FUNCTION_TRACE("acpi_memory_enable_device");
> +
> +	/* Get the range from the _CRS */
> +	result = acpi_memory_get_device_resources(mem_device);
> 
> result = acpi_walk_resources(mem_device->handle, METHOD_NAME_CRS,
>                               acpi_memory_get_device_resources,
> mem_device);
> 
> +	if (result) {
> +		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
> +			"\nget_device_resources failed\n"));
> +		mem_device->state = MEMORY_INVALID_STATE;
> +		return result;
> +	}
> 
> --
> --the clue is these footmarks leading to the door.--
> KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Hiroyuki KAMEZAWA]

S, Naveen B wrote:

>
> Thanks Kame,
> As I was mentioning earlier, my understanding from the spec that the
> memory device has only range in _CRS. So I believe acpi_walk_resources
> is redundant in this case. Anyway this could be changed if it is a real
> concern.
> Please let me know.
> 
> --Naveen
> 

Okay, thanks.
Currently, I have no *real* concern.

-- Kame <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>


> 
> 
>>S, Naveen B wrote:
>>+static int
>>+acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>+{
>>+	int result;
>>+
>>+	ACPI_FUNCTION_TRACE("acpi_memory_enable_device");
>>+
>>+	/* Get the range from the _CRS */
>>+	result = acpi_memory_get_device_resources(mem_device);
>>
>>result = acpi_walk_resources(mem_device->handle, METHOD_NAME_CRS,
>>                              acpi_memory_get_device_resources,
>>mem_device);
>>
>>+	if (result) {
>>+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
>>+			"\nget_device_resources failed\n"));
>>+		mem_device->state = MEMORY_INVALID_STATE;
>>+		return result;
>>+	}
>>
>>--
>>--the clue is these footmarks leading to the door.--
>>KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> 
> 
> 


-- 
--the clue is these footmarks leading to the door.--
KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

RE: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Dave Hansen]

Your patch contained 63 lines with trailing whitespace.  Please be
careful to strip these before submitting in the future.

-- Dave



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl