Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug Driver Patch Update

[Hiroyuki KAMEZAWA <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>]

S, Naveen B wrote:

>
> Thanks Kame,
> As I was mentioning earlier, my understanding from the spec that the
> memory device has only range in _CRS. So I believe acpi_walk_resources
> is redundant in this case. Anyway this could be changed if it is a real
> concern.
> Please let me know.
> 
> --Naveen
> 

Okay, thanks.
Currently, I have no *real* concern.

-- Kame <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>


> 
> 
>>S, Naveen B wrote:
>>+static int
>>+acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>+{
>>+	int result;
>>+
>>+	ACPI_FUNCTION_TRACE("acpi_memory_enable_device");
>>+
>>+	/* Get the range from the _CRS */
>>+	result = acpi_memory_get_device_resources(mem_device);
>>
>>result = acpi_walk_resources(mem_device->handle, METHOD_NAME_CRS,
>>                              acpi_memory_get_device_resources,
>>mem_device);
>>
>>+	if (result) {
>>+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
>>+			"\nget_device_resources failed\n"));
>>+		mem_device->state = MEMORY_INVALID_STATE;
>>+		return result;
>>+	}
>>
>>--
>>--the clue is these footmarks leading to the door.--
>>KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> 
> 
> 


-- 
--the clue is these footmarks leading to the door.--
KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl