public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* Re: Fw: ACPI bug causes cd-rom lock-ups (2.6.10-rc2)
@ 2004-12-01 20:26 matthieu castet
  0 siblings, 0 replies; 8+ messages in thread
From: matthieu castet @ 2004-12-01 20:26 UTC (permalink / raw)
  To: Linux Kernel list, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
  Cc: Adam Belay, Li, Shaohua, Len Brown

 >+/*
 >+ * We'd like PNP to call this routine for the
 >+ * single ISA_USED value for each legacy device.
 >+ * But instead it calls us with each POSSIBLE setting.
 >+ * There is no ISA_POSSIBLE weight, so we simply use
 >+ * the (small) PCI_USING penalty.
 >+ */

Couldn't be better to change the pnp core behaviour ?

In drivers/pnp/resource.c, pnp_register_irq_resource, instead of calling 
pcibios_penalize_isa_irq couldn't we call something like 
pcibios_penalize_possible_isa_irq ?

The pnp implemations already use pcibios_penalize_isa_irq [1] for the 
irq that are used.
So it seem it is call 2 times for the allocated resources...
Also don't we need to depenalize the irq, if we change the irq or 
disable the device ?

Matthieu CASTET


[1]
$grep -r penalize */*
pnpacpi/rsparser.c: 
pcibios_penalize_isa_irq(res->data.irq.interrupts[0]);
pnpacpi/rsparser.c: 
pcibios_penalize_isa_irq(res->data.extended_irq.interrupts[0]);
pnpbios/rsparser.c:             pcibios_penalize_isa_irq(irq);


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2004-12-02 16:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <41990138.7080008@aknet.ru>
     [not found] ` <41990138.7080008-D1TkPCJej5s@public.gmane.org>
2004-11-23  6:09   ` Fw: ACPI bug causes cd-rom lock-ups (2.6.10-rc2) Len Brown
2004-11-24 18:12     ` Stas Sergeev
     [not found]       ` <41A4CF1C.6090503-D1TkPCJej5s@public.gmane.org>
2004-11-24 22:44         ` Len Brown
2004-11-25 18:18           ` Stas Sergeev
     [not found]             ` <41A621DD.8060102-D1TkPCJej5s@public.gmane.org>
2004-12-01  5:41               ` Len Brown
2004-12-01  5:44                 ` Len Brown
2004-12-02 16:52                 ` Stas Sergeev
2004-12-01 20:26 matthieu castet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox