* [PATCH][BUG] LoadTable() operator fails
@ 2005-01-05 5:29 Kenji Kaneshige
[not found] ` <41DB7B2A.4020005-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Kenji Kaneshige @ 2005-01-05 5:29 UTC (permalink / raw)
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Hi,
The execution of the LoadTable() operator might fail because of the
bug on OEM ID comparison. The following patch fixes this issue.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
---
linux-2.6.10-kanesige/drivers/acpi/tables/tbxfroot.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/acpi/tables/tbxfroot.c~fix_acpi_tb_find_table
drivers/acpi/tables/tbxfroot.c
--- linux-2.6.10/drivers/acpi/tables/tbxfroot.c~fix_acpi_tb_find_table
2005-01-04 09:05:29.000000000 +0900
+++ linux-2.6.10-kanesige/drivers/acpi/tables/tbxfroot.c 2005-01-04
09:05:29.000000000 +0900
@@ -114,8 +114,8 @@ acpi_tb_find_table (
/* Check oem_id and oem_table_id */
- if ((oem_id[0] && ACPI_STRCMP (oem_id, table->oem_id)) ||
- (oem_table_id[0] && ACPI_STRCMP (oem_table_id, table->oem_table_id))) {
+ if ((oem_id[0] && ACPI_STRNCMP (oem_id, table->oem_id, sizeof
(table->oem_id))) ||
+ (oem_table_id[0] && ACPI_STRNCMP (oem_table_id, table->oem_table_id,
sizeof (table->oem_table_id)))) {
return_ACPI_STATUS (AE_AML_NAME_NOT_FOUND);
}
_
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH][BUG] LoadTable() operator fails
@ 2005-01-07 19:19 Moore, Robert
0 siblings, 0 replies; 3+ messages in thread
From: Moore, Robert @ 2005-01-07 19:19 UTC (permalink / raw)
To: Kenji Kaneshige, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Thanks, I will integrate into ACPICA
Bob
> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Kenji Kaneshige
> Sent: Thursday, January 06, 2005 6:15 PM
> To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: Re: [ACPI] [PATCH][BUG] LoadTable() operator fails
>
> Hi,
>
> My mailer inserted unnecessary line feeds into the patch.
> So I send it again.
>
> Thanks,
> Kenji Kaneshige
>
> Kenji Kaneshige wrote:
> > Hi,
> >
> > The execution of the LoadTable() operator might fail because of the
> > bug on OEM ID comparison. The following patch fixes this issue.
> >
> > Signed-off-by: Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> >
> >
> > ---
> >
> > linux-2.6.10-kanesige/drivers/acpi/tables/tbxfroot.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff -puN drivers/acpi/tables/tbxfroot.c~fix_acpi_tb_find_table
> > drivers/acpi/tables/tbxfroot.c
> > ---
linux-2.6.10/drivers/acpi/tables/tbxfroot.c~fix_acpi_tb_find_table
> > 2005-01-04 09:05:29.000000000 +0900
> > +++ linux-2.6.10-kanesige/drivers/acpi/tables/tbxfroot.c
2005-01-04
> > 09:05:29.000000000 +0900
> > @@ -114,8 +114,8 @@ acpi_tb_find_table (
> >
> > /* Check oem_id and oem_table_id */
> >
> > - if ((oem_id[0] && ACPI_STRCMP (oem_id, table->oem_id)) ||
> > - (oem_table_id[0] && ACPI_STRCMP (oem_table_id, table-
> >oem_table_id))) {
> > + if ((oem_id[0] && ACPI_STRNCMP (oem_id, table->oem_id,
sizeof
> > (table->oem_id))) ||
> > + (oem_table_id[0] && ACPI_STRNCMP (oem_table_id, table-
> >oem_table_id,
> > sizeof (table->oem_table_id)))) {
> > return_ACPI_STATUS (AE_AML_NAME_NOT_FOUND);
> > }
> >
> >
> > _
> >
> >
> > -------------------------------------------------------
> > The SF.Net email is sponsored by: Beat the post-holiday blues
> > Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
> > It's fun and FREE -- well,
almost....http://www.thinkgeek.com/sfshirt
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel
> >
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-07 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-05 5:29 [PATCH][BUG] LoadTable() operator fails Kenji Kaneshige
[not found] ` <41DB7B2A.4020005-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-01-07 2:14 ` Kenji Kaneshige
-- strict thread matches above, loose matches on Subject: below --
2005-01-07 19:19 Moore, Robert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox