From: Prarit Bhargava <prarit-sJ/iWh9BUns@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH]: Error in ACPI error handling results in WARN_ON in IDE
Date: Thu, 20 Jan 2005 08:58:07 -0500 [thread overview]
Message-ID: <41EFB8EF.7010207@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
Hello,
I found a bug in the error handling in ACPI.
The issue here is the error handling within the ACPI layer. gsi = 0 is a
valid return value from acpi_pci_irq_lookup, while gsi = (-1) is the value
returned when a PRT cannot be found.
[-- Attachment #2: 1-acpi-ide.patch --]
[-- Type: text/plain, Size: 456 bytes --]
===== drivers/acpi/pci_irq.c 1.35 vs edited =====
--- 1.35/drivers/acpi/pci_irq.c 2005-01-04 21:48:17 -05:00
+++ edited/drivers/acpi/pci_irq.c 2005-01-14 08:14:34 -05:00
@@ -487,10 +487,10 @@
* If no PRT entry was found, we'll try to derive an IRQ from the
* device's parent bridge.
*/
- if (!gsi)
+ if (gsi == -1)
gsi = acpi_pci_irq_derive(dev, pin,
&edge_level, &active_high_low);
- if (!gsi)
+ if (gsi == -1)
return_VOID;
/*
reply other threads:[~2005-01-20 13:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41EFB8EF.7010207@sgi.com \
--to=prarit-sj/iwh9buns@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox